Throw if no converter #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettsam
reviewed
Mar 3, 2021
src/DotNetWorker/Context/Features/DefaultModelBindingFeature.cs
Outdated
Show resolved
Hide resolved
src/DotNetWorker/Context/Features/DefaultModelBindingFeature.cs
Outdated
Show resolved
Hide resolved
mhoeger
force-pushed
the
mhoeger/throwIfNoConverter
branch
from
0cfd9c2 to
5ae84ea
Compare
mhoeger
commented
Mar 4, 2021
src/DotNetWorker/Context/Features/DefaultModelBindingFeature.cs
Outdated
Show resolved
Hide resolved
source can be null
mhoeger
force-pushed
the
mhoeger/throwIfNoConverter
branch
from
fba14c6 to
2f8c529
Compare
Contributor
Author
|
Increasing test coverage tracked here: #230 |
fabiocav
approved these changes
Mar 5, 2021
| internal class FunctionInputConverterException : FunctionWorkerException | ||
| { | ||
| internal FunctionInputConverterException(string message) : base(message) { } | ||
|
|
Member
There was a problem hiding this comment.
Should this have a property for the function name?
fabiocav
reviewed
Mar 5, 2021
| /// <summary> | ||
| /// Internal exception that is surfaced to the user | ||
| /// </summary> | ||
| internal class FunctionWorkerException : Exception |
Member
There was a problem hiding this comment.
Are you defining this to serve as the base for worker exceptions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of keeping the input as null if we are unable to convert it, we should throw (or at least warn) why the input is null.
Example: