Update and fix unit tests #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liliankasem
commented
Jul 10, 2023
liliankasem
commented
- Update a couple tests that were missed when converter behaviour was changed (in how we handle invalid content source and content type)
- Refactored Table unit tests
- Refactored EventGrid unit tests
aishwaryabh
reviewed
Jul 10, 2023
test/FunctionMetadataGeneratorTests/FunctionMetadataGeneratorTests.cs
Outdated
Show resolved
Hide resolved
aishwaryabh
approved these changes
Jul 10, 2023
Contributor
aishwaryabh
left a comment
aishwaryabh
left a comment
There was a problem hiding this comment.
LGTM! Thanks for refactoring the table and event grid tests :)
liliankasem
added a commit
that referenced
this pull request
Jul 20, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 21, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 21, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 26, 2023
liliankasem
added a commit
that referenced
this pull request
Aug 1, 2023
liliankasem
added a commit
that referenced
this pull request
Aug 1, 2023
liliankasem
added a commit
that referenced
this pull request
Aug 15, 2023
liliankasem
added a commit
that referenced
this pull request
Aug 15, 2023
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-functions-dotnet-worker
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.