[Build]Switching from EsrpCodeSigning@1 to EsrpCodeSigning@2 #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
requested review from
brettsam,
fabiocav,
jviau,
kashimiz,
madelinegordon,
satvu and
surgupta-msft
and removed request for
fabiocav and
jviau
satvu
approved these changes
Jan 12, 2023
fabiocav
approved these changes
Jan 13, 2023
Member
Author
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the codesigning task if failing as it requires 'Microsoft.NETCore.App', version '2.1.0 framework and looks like the agents does not have that anymore. To fix this we are switching from EsrpCodeSigning@1 to EsrpCodeSigning@2 which apparently relies on a newer version of the framework which exists in these agents.
Ran a build from this branch and CodeSigning step works now.