Adding FunctionsNetHost to worker repo #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
commented
Dec 5, 2022
| @@ -0,0 +1,55 @@ | |||
| variables: | |||
Member
Author
There was a problem hiding this comment.
I might update/adjust this file once this version is checked in.
kshyju
commented
Dec 5, 2022
| @@ -0,0 +1,26 @@ | |||
| syntax = "proto3"; | |||
Member
Author
There was a problem hiding this comment.
We could consider moving the proto files to root level on this repo so that both Worker.Grpc and host can use same proto file. Something I will investigate later.
Member
There was a problem hiding this comment.
Agreed. Can we have a follow up PR with that change?
brettsam
approved these changes
Dec 6, 2022
fabiocav
approved these changes
Dec 6, 2022
| @@ -0,0 +1,3 @@ | |||
| # net-worker-host | |||
|
|
|||
| [](https://azfunc.visualstudio.com/Azure%20Functions/_build/latest?definitionId=201&branchName=main) | |||
Member
There was a problem hiding this comment.
Should we rename the build so it doesn't carry the old repo name?
Member
Author
There was a problem hiding this comment.
will do after the new pipeline is setup.
| @@ -0,0 +1,26 @@ | |||
| syntax = "proto3"; | |||
Member
There was a problem hiding this comment.
Agreed. Can we have a follow up PR with that change?
Member
Author
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.