ChangeFeed: Fixes crts field being nullable #5512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash2710
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yash2710
changed the title
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
Outdated
Show resolved
Hide resolved
ananth7592
reviewed
Dec 1, 2025
ananth7592
reviewed
Dec 1, 2025
...rosoft.Azure.Cosmos.Encryption.Custom.Tests/Contracts/DotNetSDKEncryptionCustomAPI.net6.json
Show resolved
Hide resolved
ananth7592
previously approved these changes
Dec 1, 2025
Contributor
ananth7592
left a comment
ananth7592
left a comment
There was a problem hiding this comment.
Approved with a nit comment
Added a check in the getter for ConflictResolutionTimestampInSeconds to throw an exception if the value is not set.
ananth7592
previously approved these changes
Dec 2, 2025
...oft.Azure.Cosmos.EmulatorTests/CFP/AllVersionsAndDeletes/BuilderWithCustomSerializerTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/FullFidelity/ChangeFeedMetadata.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Dec 3, 2025
ananth7592
approved these changes
Dec 3, 2025
NaluTripician
pushed a commit
that referenced
this pull request
Jan 14, 2026
## Description Revert the change that makes crts nullable. As per internal discussion, CRTS will be backfilled with read-path filing in case of data missing. This change is to ensure that the contract is not changed ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) closes #5508
This was referenced Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert the change that makes crts nullable. As per internal discussion, CRTS will be backfilled with read-path filing in case of data missing.
This change is to ensure that the contract is not changed
Type of change
closes #5508