Fix typo in docs for ApplicationPreferredRegions #5486
Conversation
HolisticDeveloper
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
|
@microsoft-github-policy-service agree |
Pilchie
left a comment
Pilchie
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
It looks like you made a bunch of whitespace changes (maybe changed line-endings?), as well as adding an extra newline on line 1263.
Can you take a look and re-submit without the extra changes.
|
@Pilchie I noted the line endings in the description:
Is CRLF not desired? |
|
Sorry - going to quickly :( @kirankumarkolli - thoughts? |
Pilchie
dismissed
their stale review
Missed comment that file already had inconsistent line-endings.
kirankumarkolli
left a comment
kirankumarkolli
left a comment
There was a problem hiding this comment.
Can you please fix the tabs/spaces and ensure that only change?
| /// <summary> | ||
| /// Creates a new CosmosClientOptions | ||
| /// </summary> | ||
| public CosmosClientOptions() |
There was a problem hiding this comment.
@copilot please fix the PR to not update newline endings
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a grammatical error in the XML documentation for the ApplicationPreferredRegions property by removing a duplicate article "the" from the phrase "If the these invalid regions" to "If these invalid regions". The file was also reformatted with consistent CRLF line endings as specified in .editorconfig.
- Corrected typo in documentation comment for
ApplicationPreferredRegions - Reformatted file with CRLF line endings per
.editorconfigspecification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| HttpRequestMessage dummyMessage = new HttpRequestMessage(); | ||
| dummyMessage.Headers.Add(HttpConstants.HttpHeaders.UserAgent, value); |
There was a problem hiding this comment.
Disposable 'HttpRequestMessage' is created but not disposed.
| HttpRequestMessage dummyMessage = new HttpRequestMessage(); | |
| dummyMessage.Headers.Add(HttpConstants.HttpHeaders.UserAgent, value); | |
| using (HttpRequestMessage dummyMessage = new HttpRequestMessage()) | |
| { | |
| dummyMessage.Headers.Add(HttpConstants.HttpHeaders.UserAgent, value); | |
| } |
| CosmosJsonSerializerWrapper cosmosJsonSerializerWrapper = value as CosmosJsonSerializerWrapper; | ||
| if (value is CosmosJsonSerializerWrapper) |
There was a problem hiding this comment.
Variable cosmosJsonSerializerWrapper may be null at this access because of this assignment.
| CosmosJsonSerializerWrapper cosmosJsonSerializerWrapper = value as CosmosJsonSerializerWrapper; | |
| if (value is CosmosJsonSerializerWrapper) | |
| if (value is CosmosJsonSerializerWrapper cosmosJsonSerializerWrapper) |
| if (this.DisableServerCertificateValidationInvocationCallback == null) | ||
| { | ||
| return this.ServerCertificateCustomValidationCallback ?? ((_, _, _) => true); | ||
| } | ||
| else | ||
| { | ||
| return (X509Certificate2 cert, X509Chain chain, SslPolicyErrors policyErrors) => | ||
| { | ||
| bool bValidationResult = true; | ||
| if (this.ServerCertificateCustomValidationCallback != null) | ||
| { | ||
| bValidationResult = this.ServerCertificateCustomValidationCallback(cert, chain, policyErrors); | ||
| } | ||
| this.DisableServerCertificateValidationInvocationCallback?.Invoke(); | ||
| return bValidationResult; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Both branches of this 'if' statement return - consider using '?' to express intent better.
It changes the full file and impacts Blame graph for tracking changes. |
3 participants
Pull Request Template
Description
closes #5485.
Changes the phrase
to
Type of change
Please delete options that are not relevant.