HttpTimeoutPolicy Improvements Phase 2: Refactors Code to Separate out Retry Policy Timeouts for point-reads and non-point-reads on PPAF #5482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
kundadebdatta
changed the title
Read and Query scenariosRead and Query Scenarios on PPAF
ananth7592
reviewed
Nov 11, 2025
ananth7592
reviewed
Nov 11, 2025
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemIntegrationTests.cs
Outdated
Show resolved
Hide resolved
…com/Azure/azure-cosmos-dotnet-v3 into fix-split-timeout-by-operation-type
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
Nov 12, 2025
Member
FabianMeiswinkel
left a comment
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
LGTM except for the one comment about PPAF min. retry interval of 1 second
kundadebdatta
requested review from
Pilchie,
adityasa,
khdang,
kirillg,
neildsh and
sboshra
as code owners
Contributor
Author
@FabianMeiswinkel, min retry interval already updated to 1sec. Do you have anything else on that? |
Praveen-Msft
changed the title
Read and Query Scenarios on PPAF
kirankumarkolli
approved these changes
Nov 13, 2025
Praveen-Msft
added a commit
that referenced
this pull request
Nov 13, 2025
…t Retry Policy Timeouts for point-reads and non-point-reads on PPAF (#5482) # Pull Request Template ## Description This change fixes the aggressive retry timeouts for requests when PPAF enabled. This change contains distinct retry policy timeouts for respective operations and allows us to manage the timeouts separately. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #5484 --------- Co-authored-by: Debdatta Kunda <[email protected]> Co-authored-by: Debdatta Kunda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This change fixes the aggressive retry timeouts for requests when PPAF enabled. This change contains distinct retry policy timeouts for respective operations and allows us to manage the timeouts separately.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5484