Query: Fixes LINQ.Contains to handle Memory Span implicit conversion introduced in C#13/DotNet9 #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasa
reviewed
Dec 4, 2025
| if (type == typeof(Enumerable) || type == typeof(Queryable) || type == typeof(CosmosLinq)) | ||
|
|
||
| // Aside from the known types, we also need to avoid partial eval for op_implicit methods, which are the implicit conversions of enum to memoryextension span types (introduced in c#13) | ||
| if (type == typeof(Enumerable) || type == typeof(Queryable) || type == typeof(CosmosLinq) || methodCallExpression.Method.Name == "op_Implicit") |
Contributor
There was a problem hiding this comment.
Please make the check tighter so that we only let through those on_implicit calls that we support.
Contributor
There was a problem hiding this comment.
For a check that's broader than what we support, please add negative coverage for those cases.
Contributor
There was a problem hiding this comment.
Please also guard consts (for downstream success).
adityasa
reviewed
Dec 4, 2025
| && methodCallExpression.Method.Name == "op_Implicit" | ||
| && methodCallExpression.Method.DeclaringType is { IsGenericType: true } implicitCastDeclaringType | ||
| && implicitCastDeclaringType.GetGenericTypeDefinition() is var genericTypeDefinition | ||
| && (genericTypeDefinition == typeof(Span<>) || genericTypeDefinition == typeof(ReadOnlySpan<>))) |
Contributor
There was a problem hiding this comment.
Debug Assert inside if assuming this check is done at top level.
adityasa
reviewed
Dec 4, 2025
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| [TestClass] | ||
| public class Program |
Contributor
There was a problem hiding this comment.
Please rename, turn this into a test project (if not already).
adityasa
reviewed
Dec 4, 2025
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Contributor
There was a problem hiding this comment.
Please rename the project, class namespaces to something suitable that indicate these are .NET C#14 specific tests.
Contributor
There was a problem hiding this comment.
Microsoft.Azure.Cosmos.Tests.C14
adityasa
reviewed
Dec 4, 2025
| } | ||
|
|
||
| ArrayContainsVisitor visitor = new ArrayContainsVisitor(); | ||
| return visitor.VisitIN(searchExpression, (ConstantExpression)searchList, context); |
Contributor
adityasa
reviewed
Dec 4, 2025
| await container.CreateItemAsync(todoItem); | ||
| Console.WriteLine($"Created item: {todoItem.id}"); | ||
|
|
||
| string[] someStringArray = ["Learn Cosmos DB"]; |
Contributor
adityasa
reviewed
Dec 4, 2025
| <EmulatorFlavor>master</EmulatorFlavor> | ||
| <DisableCopyEmulator>True</DisableCopyEmulator> | ||
| <LangVersion>$(LangVersion)</LangVersion> | ||
| <LangVersion>preview</LangVersion> |
adityasa
reviewed
Dec 4, 2025
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <Platform>AnyCPU</Platform> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <TargetFramework>net9.0</TargetFramework> |
adityasa
reviewed
Dec 4, 2025
| List<LinqTestInput> inputs = new List<LinqTestInput> | ||
| { | ||
| { | ||
| //// Memory Span Conversion |
adityasa
reviewed
Dec 4, 2025
| Type type = methodCallExpression.Method.DeclaringType; | ||
| if (type == typeof(Enumerable) || type == typeof(Queryable) || type == typeof(CosmosLinq)) | ||
|
|
||
| // Aside from the known types, we also need to avoid partial eval for op_implicit methods, which are the implicit conversions of enum to memoryextension span types (introduced in c#13) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber