Skip to content

Query: Fixes (workaround) for query plan issue where placeholder index does not start at zero - #4885

Merged
microsoft-github-policy-service[bot] merged 5 commits into
masterfrom
users/ndeshpan/placeholderIndexWorkaround
Nov 13, 2024
Merged

Query: Fixes (workaround) for query plan issue where placeholder index does not start at zero#4885
microsoft-github-policy-service[bot] merged 5 commits into
masterfrom
users/ndeshpan/placeholderIndexWorkaround

Conversation

@neildsh

@neildsh neildsh commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Description

During query plan generation, we were using the loop index index over order by expressions as the index for placeholders within component queries. However, VectorDistance expressions do not require placeholders. As a result the output placeholder indexes may not always start at 0. The fix for this is currently in PR on the gateway.

We are putting this workaround in the SDK until the gateway fix is deployed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@neildsh neildsh added QUERY auto-merge Enables automation to merge PRs labels Nov 13, 2024

@adityasa Aditya (adityasa) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kundadebdatta Debdatta Kunda (kundadebdatta) changed the title Query: Fixes (workaround) for query plan issue where placeholder index does not start at zero [Internal] Query: Fixes (workaround) for query plan issue where placeholder index does not start at zero Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs QUERY

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants