Skip to content

Query: Fixes prefetching to be disabled when MaxConcurrency is less than or equal to one - #4649

Merged
Kiran Kumar Kolli (kirankumarkolli) merged 4 commits into
masterfrom
users/ndeshpan/prefetchFix
Nov 9, 2024
Merged

Query: Fixes prefetching to be disabled when MaxConcurrency is less than or equal to one#4649
Kiran Kumar Kolli (kirankumarkolli) merged 4 commits into
masterfrom
users/ndeshpan/prefetchFix

Conversation

@neildsh

@neildsh neildsh commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Description

Disables parallel prefetch when MaxConcurrency is less than or equal to one, since that would entail sequential fetches from the backend resulting in increased latency for no gain.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@neildsh neildsh changed the title Query: Fixes prefetching to be disabledwhen MaxConcurrency is less than or equal to one Query: Fixes prefetching to be disabled when MaxConcurrency is less than or equal to one Aug 20, 2024
@neildsh neildsh added QUERY auto-merge Enables automation to merge PRs labels Aug 20, 2024
@microsoft-github-policy-service
microsoft-github-policy-service Bot enabled auto-merge (squash) August 20, 2024 07:08

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirankumarkolli

Copy link
Copy Markdown
Member

neildsh can you please take a look at the failing query test?

@neildsh
neildsh force-pushed the users/ndeshpan/prefetchFix branch from 8eb0fcf to 63a678a Compare November 8, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs QUERY

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants