Query: Adds Distribution for MakeList and MakeSet #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

microsoft-github-policy-service merged 24 commits into master from users/ezrahaleva/MakeListDistribution

Jun 20, 2024

Contributor

ezrahaleva-msft commented May 14, 2024 •

edited

Loading

Description

Adds MakeList and MakeSet aggregate operators and implements MakeListAggregator and MakeSetAggregator.

Type of change

[] New feature (non-breaking change which adds functionality)


          added MakeList and MakeSet aggregators

e443aa3

ezrahaleva-msft requested review from adityasa, kirankumarkolli, neildsh and sboshra as code owners

May 14, 2024 14:26

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment •

edited

Loading

All good!

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Outdated Show resolved Hide resolved


          Added MakeList and MakeSet to AggregateQueryTests.cs

db1872a

ezrahaleva-msft force-pushed the users/ezrahaleva/MakeListDistribution branch from a051c76 to db1872a Compare

May 24, 2024 16:03

ezrahaleva-msft requested review from FabianMeiswinkel, ealsur and kirillg as code owners

May 24, 2024 16:03

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

ezrahaleva-msft added 5 commits

June 3, 2024 09:52


          Adjust Aggregators

b84e8e2


          Add Array Aggregate Continuation Token Test

f42c7ec


          Added group by coverage for MakeList and MakeSet

2cb739c


          address comments

7c863d4


          cleaning

ff6637c

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/AggregateQueryTests.cs Outdated Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Show resolved Hide resolved

khdang reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Show resolved Hide resolved

neildsh reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Show resolved Hide resolved


          cleaning

eec3632

ezrahaleva-msft dismissed adityasa’s stale review via

eec3632

June 17, 2024 23:04

ezrahaleva-msft added 2 commits

June 18, 2024 09:43


          cleaning, updated baseline test

918c35e


          cleaning, updated baseline test

4dc9f9d

ezrahaleva-msft changed the title ~~Distribution for MakeList and MakeSet~~ Query: Distribution for MakeList and MakeSet

ezrahaleva-msft changed the title ~~Query: Distribution for MakeList and MakeSet~~ Adds Distribution for MakeList and MakeSet

ezrahaleva-msft changed the title ~~Adds Distribution for MakeList and MakeSet~~ Query: Adds Distribution for MakeList and MakeSet


          Added coverage to QueryPlanBaselineTests.cs

f05d33f

sboshra reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Outdated Show resolved Hide resolved

sboshra reviewed

View reviewed changes

Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/Aggregate/Aggregators/MakeListAggregator.cs Show resolved Hide resolved

sboshra previously approved these changes

View reviewed changes

Contributor

sboshra left a comment


          refactored

710fc76

ezrahaleva-msft dismissed sboshra’s stale review via

710fc76

June 20, 2024 18:38

khdang approved these changes

View reviewed changes

sboshra approved these changes

View reviewed changes

Contributor

sboshra left a comment

Maya-Painter added QUERY auto-merge labels

microsoft-github-policy-service bot enabled auto-merge (squash)

June 20, 2024 22:08


          Merge branch 'master' into users/ezrahaleva/MakeListDistribution

be853ce

ezrahaleva-msft force-pushed the users/ezrahaleva/MakeListDistribution branch from dbbb07f to be853ce Compare

June 20, 2024 22:23

microsoft-github-policy-service bot merged commit 179d9a4 into master

microsoft-github-policy-service bot deleted the users/ezrahaleva/MakeListDistribution branch

June 20, 2024 23:09

This was referenced Jul 28, 2025

Bump Azure.Identity and 6 others shibayan/nuget-lock-demo#2

Closed

Bump Azure.Extensions.AspNetCore.Configuration.Secrets and 17 others HassanFad/chat-copilot#32

Closed

dependabot bot mentioned this pull request

Bump Azure.Extensions.AspNetCore.Configuration.Secrets and 17 others HassanFad/chat-copilot#33

Open

dependabot bot mentioned this pull request

deps: Bump Microsoft.Azure.Cosmos from 3.38.1 to 3.53.1 shravs21ani/UsePreferenceSolution#12

Closed

This was referenced Oct 6, 2025

deps: Bump Microsoft.Azure.Cosmos from 3.38.1 to 3.54.0 shravs21ani/UsePreferenceSolution#15

Open

Bump Microsoft.Azure.Cosmos from 3.41.0 to 3.54.0 theDiverDK/AZ-204_Application-Insights-Demo#14

Merged

dependabot bot mentioned this pull request

chore: Bump Microsoft.Azure.Cosmos from 3.38.0 to 3.54.1 datlogysoftware/datalogyGIS#10

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

neildsh neildsh left review comments

github-actions[bot] github-actions[bot] left review comments

khdang khdang approved these changes

sboshra sboshra approved these changes

adityasa adityasa left review comments

kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

ealsur Awaiting requested review from ealsur

FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

kirillg Awaiting requested review from kirillg kirillg is a code owner

Labels

auto-merge QUERY