Dpoole/cgroup fixes#47
Merged
klugorosado merged 8 commits intoAzure:feature/v2/bootstrapVMWatchfrom Jan 3, 2024
Merged
Conversation
1. use nc for a tco server instead of web server for simplicity 2. add the variables to control tolerating the failure assignment to cgroup to allow tests to run 3. add new test for the case where it fails
klugorosado
reviewed
Jan 3, 2024
zmyzheng
approved these changes
Jan 3, 2024
klugorosado
reviewed
Jan 3, 2024
klugorosado
reviewed
Jan 3, 2024
klugorosado
reviewed
Jan 3, 2024
klugorosado
approved these changes
Jan 3, 2024
Collaborator
klugorosado
left a comment
klugorosado
left a comment
There was a problem hiding this comment.
left some comments, overall looks good.
frank-pang-msft
approved these changes
Jan 3, 2024
klugorosado
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Initial checkpoint * tweak tests * tweak the scripts 1. use nc for a tco server instead of web server for simplicity 2. add the variables to control tolerating the failure assignment to cgroup to allow tests to run 3. add new test for the case where it fails * feedback * feedback * feeback * feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to support cgroup v2 and changes in behavior when cgroup assignment fails.
Initial testing of linux was fine but when we tried testing on ubuntu 22.04 we found that cgroup v2 was not enabled there so the cgroup assignment failed. In the existing code we just logged this and started the process anyway. After discussions we decided that this is wrong and we need to only run it if we are able to assign to a cgroup.
Changes are:
ncfor simplicity