Skip to content

Conversation

@mqasimsarfraz
Copy link
Member

This change adds support for the tcpdump gadget to the AKS MCP server, enabling users to troubleshoot networking issues more effectively. The gadget supports both Kubernetes and pcap-style filtering, allowing users to precisely target traffic captures when needed.

Fixes #224

Testing Done

Prompt:

Can you capture network traffic for the pod dns-request-pod in the default namespace for 15 seconds? I want to debug connectivity issues

Response:

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@d449c8a). Learn more about missing BASE report.
⚠️ Report is 145 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/components/inspektorgadget/gadgetmanager.go 0.00% 22 Missing ⚠️
internal/components/inspektorgadget/gadgets.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage        ?   37.85%           
=======================================
  Files           ?       66           
  Lines           ?     5983           
  Branches        ?        0           
=======================================
  Hits            ?     2265           
  Misses          ?     3563           
  Partials        ?      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}

jsonFormatter, _ := igjson.New(d,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shall we check the error when creating jsonFormatter (though it is not changed this time)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, nice catch!

shall we check the error when creating jsonFormatter (though it is not changed this time)?

Not sure why linter didn't catch it before but good to have it!

Copy link
Member

@gossion gossion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gossion gossion added this pull request to the merge queue Oct 25, 2025
Merged via the queue into Azure:main with commit 6c6d660 Oct 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inspektor_gadget_observability: Add support for tcpdump gadget

3 participants