-
Notifications
You must be signed in to change notification settings - Fork 23
Feat: support oauth #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat: support oauth #202
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,285 @@ | ||
| package oauth | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "fmt" | ||
| "log" | ||
| "net/http" | ||
| "strings" | ||
|
|
||
| "github.com/Azure/aks-mcp/internal/auth" | ||
| ) | ||
|
|
||
| // contextKey is a custom type for context keys to avoid collisions | ||
| type contextKey string | ||
|
|
||
| const tokenInfoKey contextKey = "token_info" | ||
|
|
||
| // AuthMiddleware handles OAuth authentication for HTTP requests | ||
| type AuthMiddleware struct { | ||
| provider *AzureOAuthProvider | ||
| serverURL string | ||
| } | ||
|
|
||
| // setCORSHeaders sets CORS headers for OAuth endpoints to allow MCP Inspector access | ||
| func (m *AuthMiddleware) setCORSHeaders(w http.ResponseWriter) { | ||
| origin := "*" // TODO: Restrict to specific origins | ||
|
|
||
| w.Header().Set("Access-Control-Allow-Origin", origin) | ||
| w.Header().Set("Access-Control-Allow-Methods", "GET, POST, OPTIONS") | ||
| w.Header().Set("Access-Control-Allow-Headers", "Content-Type, Authorization, mcp-protocol-version") | ||
| w.Header().Set("Access-Control-Max-Age", "86400") // 24 hours | ||
| w.Header().Set("Access-Control-Allow-Credentials", "false") // Explicit false for wildcard origin | ||
| } | ||
|
|
||
| // NewAuthMiddleware creates a new authentication middleware | ||
| func NewAuthMiddleware(provider *AzureOAuthProvider, serverURL string) *AuthMiddleware { | ||
| return &AuthMiddleware{ | ||
| provider: provider, | ||
| serverURL: serverURL, | ||
| } | ||
| } | ||
|
|
||
| // Middleware returns an HTTP middleware function for OAuth authentication | ||
| func (m *AuthMiddleware) Middleware(next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
|
|
||
| // Skip authentication for specific endpoints | ||
| if m.shouldSkipAuth(r) { | ||
| log.Printf("Skipping auth for path: %s\n", r.URL.Path) | ||
| next.ServeHTTP(w, r) | ||
| return | ||
| } | ||
|
|
||
| // Perform authentication | ||
| authResult := m.authenticateRequest(r) | ||
|
|
||
| if !authResult.Authenticated { | ||
| log.Printf("Authentication FAILED - handling error\n") | ||
| m.handleAuthError(w, r, authResult) | ||
| return | ||
| } | ||
|
|
||
| // Add token info to request context | ||
| ctx := context.WithValue(r.Context(), tokenInfoKey, authResult.TokenInfo) | ||
| r = r.WithContext(ctx) | ||
|
|
||
| next.ServeHTTP(w, r) | ||
| }) | ||
| } | ||
|
|
||
| // shouldSkipAuth determines if authentication should be skipped for this request | ||
| func (m *AuthMiddleware) shouldSkipAuth(r *http.Request) bool { | ||
| // Skip auth for OAuth metadata endpoints | ||
| path := r.URL.Path | ||
|
|
||
| skipPaths := []string{ | ||
| "/.well-known/oauth-protected-resource", | ||
| "/.well-known/oauth-authorization-server", | ||
| "/.well-known/openid-configuration", | ||
| "/oauth2/v2.0/authorize", | ||
| "/oauth/register", | ||
| "/oauth/callback", | ||
| "/oauth2/v2.0/token", | ||
| "/oauth/introspect", | ||
| "/health", | ||
| "/ping", | ||
| } | ||
|
|
||
| for _, skipPath := range skipPaths { | ||
| if path == skipPath { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| // authenticateRequest performs OAuth authentication on the request | ||
| func (m *AuthMiddleware) authenticateRequest(r *http.Request) *auth.AuthResult { | ||
| // Extract Bearer token from Authorization header | ||
| authHeader := r.Header.Get("Authorization") | ||
|
|
||
| if authHeader == "" { | ||
| log.Printf("OAuth DEBUG - Missing authorization header for %s %s\n", r.Method, r.URL.Path) | ||
| log.Printf("OAuth DEBUG - Request headers: %+v\n", r.Header) | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: "missing authorization header", | ||
| StatusCode: http.StatusUnauthorized, | ||
| } | ||
| } | ||
|
|
||
| // Check for Bearer token format | ||
| const bearerPrefix = "Bearer " | ||
| if !strings.HasPrefix(authHeader, bearerPrefix) { | ||
| log.Printf("FAILED - Invalid authorization header format (missing Bearer prefix)\n") | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: "invalid authorization header format", | ||
| StatusCode: http.StatusUnauthorized, | ||
| } | ||
| } | ||
|
|
||
| token := strings.TrimPrefix(authHeader, bearerPrefix) | ||
| if token == "" { | ||
| log.Printf("FAILED - Empty bearer token\n") | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: "empty bearer token", | ||
| StatusCode: http.StatusUnauthorized, | ||
| } | ||
| } | ||
|
|
||
| // Basic JWT structure validation | ||
| tokenParts := strings.Split(token, ".") | ||
| if len(tokenParts) != 3 { | ||
| log.Printf("FAILED - JWT structure validation (has %d parts, expected 3)\n", len(tokenParts)) | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: "invalid JWT structure", | ||
| StatusCode: http.StatusUnauthorized, | ||
| } | ||
| } | ||
|
|
||
| // Validate the token | ||
| tokenInfo, err := m.provider.ValidateToken(r.Context(), token) | ||
| if err != nil { | ||
| log.Printf("FAILED - Provider token validation failed: %v\n", err) | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: fmt.Sprintf("token validation failed: %v", err), | ||
| StatusCode: http.StatusUnauthorized, | ||
| } | ||
| } | ||
|
|
||
| // Validate required scopes - strict enforcement for security | ||
| if !m.validateScopes(tokenInfo.Scope) { | ||
| log.Printf("SCOPE ERROR: Token scopes %v don't match required scopes %v", tokenInfo.Scope, m.provider.config.RequiredScopes) | ||
| return &auth.AuthResult{ | ||
| Authenticated: false, | ||
| Error: "insufficient scope", | ||
| StatusCode: http.StatusForbidden, | ||
| } | ||
| } | ||
|
|
||
| return &auth.AuthResult{ | ||
| Authenticated: true, | ||
| TokenInfo: tokenInfo, | ||
| StatusCode: http.StatusOK, | ||
| } | ||
| } | ||
|
|
||
| // validateScopes checks if the token has required scopes | ||
| func (m *AuthMiddleware) validateScopes(tokenScopes []string) bool { | ||
| requiredScopes := m.provider.config.RequiredScopes | ||
| if len(requiredScopes) == 0 { | ||
| return true // No scopes required | ||
| } | ||
|
|
||
| // Check if token has at least one required scope | ||
| for _, required := range requiredScopes { | ||
| if m.hasScopePermission(required, tokenScopes) { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| // hasScopePermission checks if the token scopes satisfy the required scope | ||
| func (m *AuthMiddleware) hasScopePermission(requiredScope string, tokenScopes []string) bool { | ||
| // Direct scope match | ||
| for _, tokenScope := range tokenScopes { | ||
| if tokenScope == requiredScope { | ||
| return true | ||
| } | ||
| } | ||
|
|
||
| // Azure resource scope mapping | ||
| azureResourceMappings := map[string][]string{ | ||
| "https://management.azure.com/.default": { | ||
| "user_impersonation", | ||
| "https://management.azure.com/user_impersonation", | ||
| "https://management.azure.com/.default", | ||
| "https://management.core.windows.net/", | ||
| "https://management.azure.com/", | ||
| }, | ||
| "https://graph.microsoft.com/.default": { | ||
| "User.Read", | ||
| "https://graph.microsoft.com/User.Read", | ||
| }, | ||
| } | ||
|
|
||
| if allowedScopes, exists := azureResourceMappings[requiredScope]; exists { | ||
| for _, allowedScope := range allowedScopes { | ||
| for _, tokenScope := range tokenScopes { | ||
| if tokenScope == allowedScope { | ||
| return true | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return false | ||
| } | ||
|
|
||
| // handleAuthError handles authentication errors | ||
| func (m *AuthMiddleware) handleAuthError(w http.ResponseWriter, r *http.Request, authResult *auth.AuthResult) { | ||
| // Set CORS headers | ||
| m.setCORSHeaders(w) | ||
| w.Header().Set("Content-Type", "application/json") | ||
|
|
||
| // Add WWW-Authenticate header for 401 responses (RFC 9728 Section 5.1) | ||
| if authResult.StatusCode == http.StatusUnauthorized { | ||
| // Build the resource metadata URL | ||
| scheme := "http" | ||
| if r.TLS != nil { | ||
| scheme = "https" | ||
| } | ||
| host := r.Host | ||
| if host == "" { | ||
| host = r.URL.Host | ||
| } | ||
| serverURL := fmt.Sprintf("%s://%s", scheme, host) | ||
| resourceMetadataURL := fmt.Sprintf("%s/.well-known/oauth-protected-resource", serverURL) | ||
|
|
||
| // RFC 9728 compliant WWW-Authenticate header | ||
| wwwAuth := fmt.Sprintf(`Bearer realm="%s", resource_metadata="%s"`, serverURL, resourceMetadataURL) | ||
|
|
||
| // Add error information if available | ||
| if authResult.Error != "" { | ||
| wwwAuth += fmt.Sprintf(`, error="invalid_token", error_description="%s"`, authResult.Error) | ||
| } | ||
|
|
||
| w.Header().Set("WWW-Authenticate", wwwAuth) | ||
| } | ||
|
|
||
| w.WriteHeader(authResult.StatusCode) | ||
|
|
||
| errorResponse := map[string]interface{}{ | ||
| "error": getOAuthErrorCode(authResult.StatusCode), | ||
| "error_description": authResult.Error, | ||
| } | ||
|
|
||
| if err := json.NewEncoder(w).Encode(errorResponse); err != nil { | ||
| log.Printf("MIDDLEWARE ERROR: Failed to encode error response: %v\n", err) | ||
| } else { | ||
| log.Printf("MIDDLEWARE ERROR: Error response sent\n") | ||
| } | ||
| } | ||
|
|
||
| // getOAuthErrorCode returns appropriate OAuth error code for HTTP status | ||
| func getOAuthErrorCode(statusCode int) string { | ||
| switch statusCode { | ||
| case http.StatusUnauthorized: | ||
| return "invalid_token" | ||
| case http.StatusForbidden: | ||
| return "insufficient_scope" | ||
| case http.StatusBadRequest: | ||
| return "invalid_request" | ||
| default: | ||
| return "server_error" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.