Skip to content

Conversation

@feiskyer
Copy link
Member

@feiskyer feiskyer commented Sep 4, 2025

Currently, only exit code 1 is shown on tool call failure, so that MCP clients won't know why that fails.

This PR adds the error message as part of tool call result and also enriches the unit tests.

Copy link
Member

@mqasimsarfraz mqasimsarfraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks for the fix!

Image

Copy link
Member

@gossion gossion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix.

@gossion gossion added this pull request to the merge queue Sep 5, 2025
Merged via the queue into main with commit 8ad3e53 Sep 5, 2025
9 checks passed
@gossion gossion deleted the fix-err-output branch September 5, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants