[HLD] DSCP/TC remapping for tunnel traffic #950
Merged
bingwang-ms merged 14 commits intosonic-net:masterfrom Mar 29, 2022
Merged
[HLD] DSCP/TC remapping for tunnel traffic #950bingwang-ms merged 14 commits intosonic-net:masterfrom
bingwang-ms merged 14 commits intosonic-net:masterfrom
Conversation
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
prsunny
reviewed
Feb 25, 2022
neethajohn
reviewed
Feb 25, 2022
neethajohn
reviewed
Feb 25, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
lguohan
reviewed
Mar 2, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
lguohan
reviewed
Mar 5, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
6 tasks
stephenxs
reviewed
Mar 9, 2022
doc/qos/tunnel_dscp_remapping.md
Outdated
| "1": "0", | ||
| "2": "0", | ||
| "3": "2", | ||
| "4": "6", |
Collaborator
There was a problem hiding this comment.
Does that mean PG 2 and 6 will be used as lossless PG? In that case BUFFER_PG|<port>|2, BUFFER_PG|<port>|6 need to be configured. But traditional buffer manager supports 3-4 only. This also needs to be updated
#define LOSSLESS_PGS "3-4"
string buffer_pg_key = port + m_cfgBufferPgTable.getTableNameSeparator() + LOSSLESS_PGS;
stephenxs
reviewed
Mar 9, 2022
vmittal-msft
reviewed
Mar 9, 2022
Contributor
vmittal-msft
left a comment
vmittal-msft
left a comment
There was a problem hiding this comment.
Reviewed and requested for meeting to discuss changes.
lguohan
reviewed
Mar 15, 2022
bingwang-ms
force-pushed
the
pcbb_dscp_remapping
branch
from
f515bac to
77421b1
Compare
Signed-off-by: bingwang <bingwang@microsoft.com>
bingwang-ms
force-pushed
the
pcbb_dscp_remapping
branch
from
77421b1 to
55024e8
Compare
Signed-off-by: bingwang <bingwang@microsoft.com>
stephenxs
reviewed
Mar 24, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
neethajohn
reviewed
Mar 24, 2022
stephenxs
reviewed
Mar 25, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
neethajohn
reviewed
Mar 25, 2022
Signed-off-by: bingwang <bingwang@microsoft.com>
neethajohn
approved these changes
Mar 29, 2022
6 tasks
neethajohn
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 5, 2022
Signed-off-by: bingwang bingwang@microsoft.com What I did This PR is to update db_migrator to support pfcwd_sw_enable. Currently, table pfc_enable is to specify on which queue to enable PFC and pfc watchdog. As we are going to add two extra lossless queues on which on watchdog is enable(HLD sonic-net/SONiC#950), a new field is required to specify on which queue to enable PFC watchdog. That is pfcwd_sw_enable. Field Description pfc_enable Specify on which queues to enable PFC pfcwd_sw_enable Specify on which queues to enable software PFC watchdog HLD DSCP remapping Change in orchagent Update orchagent to support new field pfcwd_sw_enable How I did it Update db_migrator. How to verify it Verified by UT Verified by copying the updated db_migrator.py to a SONiC box and run db_migrator.py -o migrate
This was referenced Apr 7, 2022
6 tasks
This was referenced Apr 29, 2022
[202012][cherry-pick]Update orchagent to support new field
pfcwd_sw_enable
sonic-net/sonic-swss#2245
Merged
Collaborator
|
@bingwang-ms please add the code PR list for tracking |
Collaborator
|
@bingwang-ms would you please add the code PRs by following EVPN VxLAN update for platforms using P2MP tunnel based L2 forwarding by dgsudharsan · Pull Request #806 · Azure/SONiC (github.com) as an example? |
neethajohn
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 2, 2022
Signed-off-by: bingwang <bingwang@microsoft.com> Why I did it This PR is to add two extra lossless queues for bounced back traffic. HLD sonic-net/SONiC#950 SKUs include Arista-7050CX3-32S-C32 Arista-7050CX3-32S-D48C8 Arista-7260CX3-D108C8 Arista-7260CX3-C64 Arista-7260CX3-Q64 How I did it Update the buffers.json.j2 template and buffers_config.j2 template to generate new BUFFER_QUEUE table. For T1 devices, queue 2 and queue 6 are set as lossless queues on T0 facing ports. For T0 devices, queue 2 and queue 6 are set as lossless queues on T1 facing ports. Queue 7 is added as a new lossy queue as DSCP 48 is mapped to TC 7, and then mapped into Queue 7 How to verify it Verified by UT Verified by coping the new template and generate buffer config with sonic-cfggen
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 22, 2022
Signed-off-by: bingwang <bingwang@microsoft.com> Why I did it This PR is to add two extra lossless queues for bounced back traffic. HLD sonic-net/SONiC#950 SKUs include Arista-7050CX3-32S-C32 Arista-7050CX3-32S-D48C8 Arista-7260CX3-D108C8 Arista-7260CX3-C64 Arista-7260CX3-Q64 How I did it Update the buffers.json.j2 template and buffers_config.j2 template to generate new BUFFER_QUEUE table. For T1 devices, queue 2 and queue 6 are set as lossless queues on T0 facing ports. For T0 devices, queue 2 and queue 6 are set as lossless queues on T1 facing ports. Queue 7 is added as a new lossy queue as DSCP 48 is mapped to TC 7, and then mapped into Queue 7 How to verify it Verified by UT Verified by coping the new template and generate buffer config with sonic-cfggen
skbarista
pushed a commit
to skbarista/sonic-buildimage
that referenced
this pull request
Aug 17, 2022
Signed-off-by: bingwang <bingwang@microsoft.com> Why I did it This PR is to add two extra lossless queues for bounced back traffic. HLD sonic-net/SONiC#950 SKUs include Arista-7050CX3-32S-C32 Arista-7050CX3-32S-D48C8 Arista-7260CX3-D108C8 Arista-7260CX3-C64 Arista-7260CX3-Q64 How I did it Update the buffers.json.j2 template and buffers_config.j2 template to generate new BUFFER_QUEUE table. For T1 devices, queue 2 and queue 6 are set as lossless queues on T0 facing ports. For T0 devices, queue 2 and queue 6 are set as lossless queues on T1 facing ports. Queue 7 is added as a new lossy queue as DSCP 48 is mapped to TC 7, and then mapped into Queue 7 How to verify it Verified by UT Verified by coping the new template and generate buffer config with sonic-cfggen
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
Signed-off-by: bingwang bingwang@microsoft.com What I did This PR is to update db_migrator to support pfcwd_sw_enable. Currently, table pfc_enable is to specify on which queue to enable PFC and pfc watchdog. As we are going to add two extra lossless queues on which on watchdog is enable(HLD sonic-net/SONiC#950), a new field is required to specify on which queue to enable PFC watchdog. That is pfcwd_sw_enable. Field Description pfc_enable Specify on which queues to enable PFC pfcwd_sw_enable Specify on which queues to enable software PFC watchdog HLD DSCP remapping Change in orchagent Update orchagent to support new field pfcwd_sw_enable How I did it Update db_migrator. How to verify it Verified by UT Verified by copying the updated db_migrator.py to a SONiC box and run db_migrator.py -o migrate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The high-level design doc for DSCP/TC remapping for tunnel traffic.
The implementation PRs are
TC_TO_DSCP_MAPfor DSCP rewritingAZURE_TUNNELtable for QoS remapping