Skip to content

#505 - mark GetUnadjustedFrameLength as virtual#506

Merged
nayato merged 1 commit intoAzure:devfrom
dimdeli:dev
Oct 15, 2019
Merged

#505 - mark GetUnadjustedFrameLength as virtual#506
nayato merged 1 commit intoAzure:devfrom
dimdeli:dev

Conversation

@dimdeli
Copy link
Copy Markdown
Contributor

@dimdeli dimdeli commented Jul 31, 2019

No description provided.

@dimdeli
Copy link
Copy Markdown
Contributor Author

dimdeli commented Jul 31, 2019

In Java, all non-static methods are by default "virtual functions." Only methods marked with the keyword final, which cannot be overridden, along with private methods, which are not inherited, are non-virtual.

https://github.com/netty/netty/blob/4.1/codec/src/main/java/io/netty/handler/codec/LengthFieldBasedFrameDecoder.java#L452

@nayato nayato merged commit 5bfd679 into Azure:dev Oct 15, 2019
@sunliusi
Copy link
Copy Markdown

sunliusi commented Mar 5, 2020

can you publish a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants