fix: Revert "fix: widen fs.file-max sysctl from int32 to int64 (#8640)"#8658
Merged
Conversation
This reverts commit 0af3ae2.
pdamianov-dev
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
PR Title Lint Failed ❌Current Title: Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns: Conventional Commits Format:
Guidelines:
Examples:
Please update your PR title and the lint check will run again automatically. |
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pdamianov-dev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the recent widening of the fs.file-max sysctl configuration field from int32 to int64 across the AgentBaker datamodel and the aks-node-controller protobuf API, restoring the previous int32 type.
Changes:
- Reverted
SysctlConfig.FsFileMaxinpkg/agent/datamodelfrom*int64back to*int32. - Reverted
SysctlConfig.fs_file_maxin the protobuf schema fromint64back toint32. - Updated the generated Go protobuf code to match the reverted schema.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Reverts FsFileMax back to *int32 in the public datamodel. |
| aks-node-controller/proto/aksnodeconfig/v1/custom_linux_os_config.proto | Reverts fs_file_max protobuf field back to int32. |
| aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go | Regenerated/updated Go bindings consistent with the reverted proto type. |
Files not reviewed (1)
- aks-node-controller/pkg/gen/aksnodeconfig/v1/custom_linux_os_config.pb.go: Language not supported
| NetNetfilterNfConntrackBuckets *int32 `json:"netNetfilterNfConntrackBuckets,omitempty"` | ||
| FsInotifyMaxUserWatches *int32 `json:"fsInotifyMaxUserWatches,omitempty"` | ||
| FsFileMax *int64 `json:"fsFileMax,omitempty"` | ||
| FsFileMax *int32 `json:"fsFileMax,omitempty"` |
| optional int32 net_netfilter_nf_conntrack_buckets = 20; | ||
| optional int32 fs_inotify_max_user_watches = 21; | ||
| optional int64 fs_file_max = 22; | ||
| optional int32 fs_file_max = 22; |
awesomenix
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0af3ae2.
What this PR does / why we need it: Revert "fix: widen fs.file-max sysctl from int32 to int64 (#8640)" to fix breaking issue
Which issue(s) this PR fixes:
Fixes #