chore(e2e): remove usage of deprecated secure TLS bootstrap client deadline NBC field#8635
Merged
Merged
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E test suite to stop using the deprecated SecureTLSBootstrappingConfig.Deadline field, and instead relies on the newer per-RPC secure TLS bootstrapping timeout fields when converting NBC → aksnodeconfigv1 for scriptless scenarios.
Changes:
- Removed
SecureTLSBootstrappingConfig.Deadlineoverrides from secure TLS bootstrapping fallback E2E scenarios (Linux + Windows). - Updated the NBC →
aksnodeconfigv1.BootstrappingConfigtranslation to populate the newer per-step secure TLS bootstrapping timeout fields instead of the deprecated deadline field.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
e2e/scenario_win_test.go |
Removes deprecated secure TLS bootstrapping Deadline usage in the Windows 2022 fallback scenario. |
e2e/scenario_test.go |
Removes deprecated secure TLS bootstrapping Deadline usage in multiple Linux fallback scenarios. |
e2e/node_config.go |
Switches scriptless NBC → aksnodeconfigv1 mapping from deprecated deadline to per-RPC secure TLS bootstrapping timeouts. |
Devinwong
reviewed
Jun 3, 2026
| SecureTlsBootstrappingCustomClientDownloadUrl: to.Ptr(nbc.SecureTLSBootstrappingConfig.GetCustomClientDownloadURL()), | ||
| TlsBootstrappingToken: nbc.KubeletClientTLSBootstrapToken, | ||
| SecureTlsBootstrappingValidateKubeconfigTimeout: to.Ptr(nbc.SecureTLSBootstrappingConfig.GetValidateKubeconfigTimeout()), | ||
| SecureTlsBootstrappingGetAccessTokenTimeout: to.Ptr(nbc.SecureTLSBootstrappingConfig.GetGetAccessTokenTimeout()), |
Collaborator
There was a problem hiding this comment.
naming nit: GetGetAccessTokenTimeout the naming looks awkward
Contributor
Author
There was a problem hiding this comment.
can't change that in this PR, I might look at changing in a separate PR
Devinwong
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
remove usage of deprecated secure TLS bootstrap client deadline NBC field
Which issue(s) this PR fixes:
Fixes #