fix(security): bump Go to 1.25.10 and golang.org/x/net to v0.55.0#8551
Merged
Conversation
Fixes CVE-2026-39820 (net/mail DoS via crafted addresses) and CVE-2026-39817 (cmd/go pack subcommand directory traversal) tracked in IcM 796913379. Go 1.24 reached EOL in February 2026 and does not receive security backports — Go 1.25.10 is the IcM-mandated target. golang.org/x/net v0.55.0 also fixes IPv6 host parsing issues and is required to build on Go 1.25. Updates: * 7 go.mod files: go directive 1.24.12 -> 1.25.10 (root, e2e, aks-node-controller, vhdbuilder/lister, vhdbuilder/prefetch, hack/tools, image-fetcher) * golang.org/x/net v0.49.0 -> v0.55.0 in root, e2e, and aks-node-controller modules (with go mod tidy) * 7 GitHub Actions workflows: go-version '1.24' -> '1.25' (check-coverage, copilot-setup-steps, go-test, golangci-lint, shellcheck, shellspec, validate-components) * e2e/config/config.go:182: fix bad %w usage inside fmt.Sprintf (Go 1.25 vet catches this; %w is only valid in fmt.Errorf). Verified: * go build ./... passes in all 7 modules * go vet ./... passes (e2e %w bug fixed) * No new test regressions; two pre-existing failures on main (aks-node-controller TestDownloadHotfix_MatchingBaseUpgrades and vhdbuilder/prefetch/internal/containerimage TestContainerImage) are not caused by this change. IcM: 796913379 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Go toolchain and key golang.org/x/* dependencies to address security CVEs (per IcM 796913379), and aligns CI workflows with the new Go version.
Changes:
- Bump all 7 Go modules’
go.modlanguage/toolchain version from1.24.12to1.25.10. - Update
golang.org/x/nettov0.55.0(and associatedx/sys/x/text/x/crypto/x/termbumps viago mod tidy) with refreshedgo.sumfiles. - Update GitHub Actions workflows to use Go
1.25, plus a smalle2evet-fix (%w→%vinfmt.Sprintf).
Reviewed changes
Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Bumps root module Go version and updates indirect golang.org/x/* versions. |
go.sum |
Refreshes root dependency checksums for updated golang.org/x/* versions. |
e2e/go.mod |
Bumps e2e module Go version and updates golang.org/x/* dependencies (direct/indirect). |
e2e/go.sum |
Refreshes e2e dependency checksums for updated golang.org/x/* versions. |
e2e/config/config.go |
Fixes invalid %w usage in fmt.Sprintf to satisfy stricter vetting. |
aks-node-controller/go.mod |
Bumps module Go version and updates indirect x/sys. |
aks-node-controller/go.sum |
Refreshes dependency checksums for updated golang.org/x/* versions. |
vhdbuilder/prefetch/go.mod |
Bumps module Go version to 1.25.10. |
vhdbuilder/lister/go.mod |
Bumps module Go version to 1.25.10. |
image-fetcher/go.mod |
Bumps module Go version to 1.25.10. |
hack/tools/go.mod |
Bumps tools module Go version to 1.25.10. |
.github/workflows/check-coverage.yml |
Updates CI Go version to 1.25. |
.github/workflows/copilot-setup-steps.yml |
Updates setup steps Go version to 1.25. |
.github/workflows/go-test.yml |
Updates unit-test workflow Go version to 1.25. |
.github/workflows/golangci-lint.yml |
Updates lint workflow Go version to 1.25. |
.github/workflows/shellcheck.yml |
Updates shell lint workflow Go version to 1.25. |
.github/workflows/shellspec.yaml |
Updates shellspec workflow Go version to 1.25. |
.github/workflows/validate-components.yml |
Updates validation workflows to Go 1.25 / go-version-file consumption. |
This was referenced May 22, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 22, 2026
Closed
Closed
Closed
djsly
added a commit
to djsly/AgentBaker
that referenced
this pull request
May 22, 2026
Backport of Azure#8551. Fixes CVE-2026-39820 and CVE-2026-39817. Addresses IcM 796913379. Moves off Go 1.24 EOL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 22, 2026
Closed
Closed
cameronmeissner
approved these changes
May 22, 2026
Closed
3 tasks
This was referenced May 22, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Go toolchain and
golang.org/x/netto address upstream CVEs.net/mail(stdlib)cmd/gopacksubcommand directory traversalcmd/go(stdlib)golang.org/x/netWhy the bump to 1.25 (not just a 1.24.x patch)
Go 1.24 reached EOL in February 2026 and does NOT receive security backports. There is no
go1.24.13shipping with these fixes —go1.25.10is the only release stream that contains them.Additionally,
golang.org/x/net v0.51.0and later requirego 1.25.0in their owngo.mod, so bumping x/net to the latest secure version forces the Go bump regardless.Changes
7
go.modfiles bumped fromgo 1.24.12→go 1.25.10, withgo mod tidyto refreshgo.sum:go.mod(root)e2e/go.modaks-node-controller/go.modvhdbuilder/lister/go.modvhdbuilder/prefetch/go.modhack/tools/go.modimage-fetcher/go.modgolang.org/x/netv0.49.0→v0.55.0in: root,e2e/,aks-node-controller/.7 GitHub Actions workflows bumped
go-version: '1.24'→'1.25':check-coverage.yml,copilot-setup-steps.yml,go-test.yml,golangci-lint.yml,shellcheck.yml,shellspec.yaml,validate-components.ymlvalidate-components.yml:62usesgo-version-file: e2e/go.mod— auto-picks up.)Bonus fix:
e2e/config/config.go:182— replacedfmt.Sprintf(..., %w, err)with%v.%wis only valid infmt.Errorf; Go 1.25's strictergo vetcatches this. Same panic message, correct verb.Verification
go build ./...passes in all 7 modulesgo vet ./...passes in all 7 modules (the e2e%wbug fix unblocked it)main(aks-node-controller/TestDownloadHotfix_MatchingBaseUpgradesandvhdbuilder/prefetch/internal/containerimage/TestContainerImage) are unrelated to this change — they fail identically without my diff.go 1.25runners — if any runner doesn't yet have 1.25 cached, fall back to pinning'1.25.10'instead of'1.25'in the workflow files.Backport plan
After this lands on
main, the same patch will be cherry-picked to the 14 officialofficial/vYYYYMMDDbranches that back the supported AB tags. Each backport will produce TWO tags off the branch:v0.<date>.<N+1>(AgentBaker module)aks-node-controller/v0.<date>.<N+1>(aks-node-controller submodule)→ 28 new tags total across all branches.
Related
🤖 Generated with GitHub Copilot CLI