fix: use compact JSON in ANC hotfix injection#8410
Merged
Conversation
Use json.dumps separators=(',', ':') to produce compact JSON
without spaces, matching the format in anc-hotfix-version.json
for consistent idempotent regeneration.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Devinwong
requested review from
AbelHu,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
awesomenix
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the ANC hotfix injection script emit compact JSON so the injected aks-node-controller-hotfix.json content matches hotfix/anc-hotfix-version.json formatting exactly, ensuring idempotent regeneration in the GitHub Action flow introduced in #8405.
Changes:
- Serialize the injected hotfix JSON using compact separators
(',', ':')to remove whitespace after:.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses compact JSON serialization (
separators=(',', ':')) inhotfix/anc_hotfix_generate.pyso the injected content matches the format ofhotfix/anc-hotfix-version.jsonexactly.Before:
{"version": "202504.27.0"}(space after colon)After:
{"version":"202504.27.0"}(compact, matches source file)This ensures idempotent regeneration — re-running the script produces identical output.
Follow-up to #8405.