ci: add --min-tls-version TLS1_2 to storage account creation in VHD build scripts#8210
Merged
Conversation
…sfy CloudGov policy Agent-Logs-Url: https://github.com/Azure/AgentBaker/sessions/0af61bd0-7400-4343-804a-11456cc65228 Co-authored-by: djsly <4981802+djsly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CloudGov_MinTLSStorAccnt_DENY policy for storage accounts
Add --min-tls-version TLS1_2 to storage account creation in VHD build scripts
Mar 31, 2026
djsly
approved these changes
Mar 31, 2026
djsly
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
djsly
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates VHD build helper scripts to ensure newly created temporary storage accounts comply with the CloudGov_MinTLSStorAccnt_DENY Azure Policy by explicitly setting the minimum TLS version to TLS 1.2 during creation, preventing VHD prefetch and Windows VHD build failures.
Changes:
- Add
--min-tls-version TLS1_2to the temp storage account creation in the prefetch optimization flow. - Add
--min-tls-version TLS1_2to the Windows base-image import storage account creation used by Packer settings generation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vhdbuilder/prefetch/scripts/optimize.sh | Sets --min-tls-version TLS1_2 when creating the prefetch temporary storage account. |
| vhdbuilder/packer/produce-packer-settings-functions.sh | Sets --min-tls-version TLS1_2 when creating the Windows build storage account. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
djsly
approved these changes
Mar 31, 2026
djsly
changed the title
djsly
changed the title
djsly
changed the title
cameronmeissner
approved these changes
Mar 31, 2026
timmy-wright
pushed a commit
that referenced
this pull request
Apr 2, 2026
…uild scripts (#8210) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: djsly <4981802+djsly@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
r2k1
pushed a commit
that referenced
this pull request
Apr 8, 2026
…uild scripts (#8210) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: djsly <4981802+djsly@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CloudGov_MinTLSStorAccnt_DENYpolicy (enforced at management group level ~March 31, 2026) denies creation of storage accounts withoutminimumTlsVersionset toTLS1_2+, breaking VHD prefetch and Windows VHD builds.Changes
vhdbuilder/prefetch/scripts/optimize.sh— Add--min-tls-version TLS1_2toaz storage account createincreate_temp_storage(called bypacker.mkprefetchtarget)vhdbuilder/packer/produce-packer-settings-functions.sh— Add--min-tls-version TLS1_2toaz storage account createincreate_windows_storage_accounte2e/config/azure.goalready hadMinimumTLSVersion: TLS1_2set and required no changes.