fix: set RemainAfterExit=yes for resolv-uplink-override.service#8177
Merged
Conversation
aadhar-agarwal
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VHD builder’s resolv-uplink-override.service systemd unit definition to avoid rerunning a oneshot dependency every time kubelet restarts, reducing repeated /etc/resolv.conf relinking during node lifecycle.
Changes:
- Set
RemainAfterExit=yesfor theType=oneshotresolv-uplink-override.serviceunit so systemd keeps it “active” after the first successful run.
henryli001
approved these changes
Mar 26, 2026
awesomenix
approved these changes
Mar 26, 2026
Contributor
…ot keep restarting
aadhar-agarwal
force-pushed
the
aadagarwal/remainafterexit
branch
from
3c30f4b to
d3a7543
Compare
Contributor
Author
Thanks, updated! Kicked off another run - https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=158365001&view=results |
ganeshkumarashok
approved these changes
Mar 26, 2026
aadhar-agarwal
changed the title
r2k1
pushed a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set RemainAfterExit=yes for resolve-uplink-override.service
The resolve-uplink-override.service is a Type=oneshot unit that is RequiredBy=kubelet.service. With RemainAfterExit=no, systemd considers the service inactive after its ExecStart completes. Every time kubelet restarts, systemd re-triggers this dependency, causing the service to run repeatedly. Setting RemainAfterExit=yes keeps the unit in an active state after execution, preventing unnecessary restarts on each kubelet restart cycle.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #