Skip to content

feat: download azure acr credential provider via oras in network isolated windows cluster#8152

Merged
fseldow merged 13 commits into
mainfrom
xinhl/windowscredentialprovider
Mar 27, 2026
Merged

feat: download azure acr credential provider via oras in network isolated windows cluster#8152
fseldow merged 13 commits into
mainfrom
xinhl/windowscredentialprovider

Conversation

@fseldow

@fseldow fseldow commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

feat: download azure acr credential provider via oras in network isolated windows cluster

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows CSE credential provider installation flow to support network-isolated clusters by downloading the Azure ACR credential provider artifact via ORAS when a bootstrap registry is configured.

Changes:

  • Add ORAS-based download + unzip path for credential provider when BootstrapProfileContainerRegistryServer is set.
  • Derive the credential provider version from CredentialProviderURL (with fallback to KubeBinariesVersion) to build an ORAS reference.
  • Improve error reporting by using a dynamic exit code depending on the download mechanism.

Comment thread staging/cse/windows/configfunc.ps1 Outdated
Comment thread staging/cse/windows/configfunc.ps1
Comment thread staging/cse/windows/configfunc.ps1 Outdated
Comment thread staging/cse/windows/configfunc.ps1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 23, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread staging/cse/windows/configfunc.ps1
Comment thread staging/cse/windows/configfunc.ps1 Outdated
Comment thread staging/cse/windows/configfunc.ps1 Outdated
Copilot AI review requested due to automatic review settings March 25, 2026 04:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread staging/cse/windows/configfunc.ps1
Comment thread staging/cse/windows/configfunc.tests.ps1
Copilot AI review requested due to automatic review settings March 25, 2026 04:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread staging/cse/windows/configfunc.tests.ps1
@fseldow fseldow force-pushed the xinhl/windowscredentialprovider branch from 2d5959d to 9c40a8a Compare March 25, 2026 04:47
Copilot AI review requested due to automatic review settings March 25, 2026 04:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread staging/cse/windows/configfunc.ps1
Comment thread staging/cse/windows/configfunc.tests.ps1
Comment thread staging/cse/windows/configfunc.tests.ps1
@fseldow

fseldow commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@fseldow fseldow requested a review from timmy-wright March 26, 2026 01:17
@fseldow fseldow merged commit cd02f0d into main Mar 27, 2026
33 checks passed
@fseldow fseldow deleted the xinhl/windowscredentialprovider branch March 27, 2026 02:53
r2k1 pushed a commit that referenced this pull request Apr 8, 2026
…ated windows cluster (#8152)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants