fix(windows): move add kubelet failure restart code#8142
Merged
Conversation
timmy-wright
requested review from
AbelHu,
Devinwong,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the Windows service failure-action configuration to run during the cluster-integration phase (NodePrep) instead of during base image preparation (BasePrep), aligning it with when kubelet/kubeproxy services are actually created/configured.
Changes:
- Removed
Update-ServiceFailureActionsfromBasePrep. - Added
Update-ServiceFailureActionstoNodePrepso it runs during provisioning after NodePrep work.
r2k1
approved these changes
Mar 20, 2026
r2k1
pushed a commit
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code has to run after the kubelet, kubeproxy, and containerd services have been configured. Which doesn't happen until nodeprep.
Discovered this while adding comprehensive error handling to the windows provisioning scripts.
What this PR does / why we need it:
So kubelet, kubeproxy, and containerd system services start as expected.
Which issue(s) this PR fixes:
Fixes #