Skip to content

feat: unblock artifact streaming for arm64 nodes and remove support on mariner#8103

Merged
KananMehta merged 4 commits into
mainfrom
kananmehta/artistreaming-arm64
Mar 19, 2026
Merged

feat: unblock artifact streaming for arm64 nodes and remove support on mariner#8103
KananMehta merged 4 commits into
mainfrom
kananmehta/artistreaming-arm64

Conversation

@KananMehta

@KananMehta KananMehta commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Required to enable artifact streaming on arm nodepools. Also bump binary version and remove path for AzLinux 2.0 since it is being deprecated and there is no new binary for it.

Copilot AI review requested due to automatic review settings March 16, 2026 21:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds ARM64 support for artifact streaming packages. Previously, ARM64 architectures were excluded from artifact streaming installation; now the code appends -arm64 to the package name when running on ARM64 and removes the ARM64 exclusion guards.

Changes:

  • Append -arm64 suffix to the artifact streaming package name when building on ARM64
  • Remove isARM64 exclusion checks for Ubuntu, Mariner 2.0, and Azure Linux 3.0
  • Fix MIRROR_DOWNLOAD_PATH to use the (potentially modified) PACKAGE_NAME variable instead of $1
Comments suppressed due to low confidence (1)

vhdbuilder/packer/install-dependencies.sh:536

  • Lines 534 and 536 still reference $2 directly instead of using $PACKAGE_EXTENSION. While functionally equivalent, this is inconsistent with the change on line 531 where $1 was replaced with $PACKAGE_NAME / $PACKAGE_EXTENSION. For consistency and clarity, these should also use $PACKAGE_EXTENSION.
  if [ "$2" = "deb" ]; then
    apt_get_install 30 1 600 $MIRROR_DOWNLOAD_PATH || exit $ERR_ARTIFACT_STREAMING_DOWNLOAD
  elif [ "$2" = "rpm" ]; then

You can also share your feedback on Copilot code review. Take the survey.

@KananMehta KananMehta force-pushed the kananmehta/artistreaming-arm64 branch from c111277 to 8117c2b Compare March 17, 2026 15:15
@KananMehta KananMehta changed the title feat: remove add arm64 support for artifact streaming feat: remove arm64 gate for artifact streaming Mar 17, 2026
Copilot AI review requested due to automatic review settings March 18, 2026 23:04
@KananMehta KananMehta force-pushed the kananmehta/artistreaming-arm64 branch from 9edf207 to 0e5c13d Compare March 18, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables artifact streaming on ARM64 Linux node images by removing the previous ARM64 gating and selecting architecture-specific artifact streaming packages during VHD build.

Changes:

  • Append -arm64 to the artifact streaming package name when building on ARM64.
  • Remove the ARM64 exclusion for Ubuntu (20.04+) artifact streaming enablement.
  • Update artifact streaming package version from 0.3.0 to 0.3.1 and narrow Azure Linux logic to 3.0 only.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread vhdbuilder/packer/install-dependencies.sh
@KananMehta KananMehta force-pushed the kananmehta/artistreaming-arm64 branch from 0e5c13d to acd3c11 Compare March 18, 2026 23:09
@KananMehta KananMehta marked this pull request as ready for review March 19, 2026 14:32
Copilot AI review requested due to automatic review settings March 19, 2026 14:32
@KananMehta KananMehta changed the title feat: remove arm64 gate for artifact streaming feat: unblock artifact streaming for arm64 nodes Mar 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables artifact streaming on ARM64 nodepools by switching the artifact package name to an -arm64 variant at install time, and removes the Azure Linux 2.0 artifact streaming path due to deprecation.

Changes:

  • Update artifact streaming installer to download ARM64-specific packages on ARM64 hosts.
  • Bump mirror proxy version from 0.3.0 to 0.3.1.
  • Remove artifact streaming enablement path for Azure Linux 2.0; keep Azure Linux 3.0.
Comments suppressed due to low confidence (1)

vhdbuilder/packer/install-dependencies.sh:539

  • Unquoted variable expansions here can cause word-splitting/globbing issues (and rm is especially risky). Quote "$MIRROR_DOWNLOAD_PATH" and "$MIRROR_PROXY_URL" when passing them as arguments, and quote the path in rm as well.
  retrycmd_curl_file 10 5 60 $MIRROR_DOWNLOAD_PATH $MIRROR_PROXY_URL || exit ${ERR_ARTIFACT_STREAMING_DOWNLOAD}
  if [ "$2" = "deb" ]; then
    apt_get_install 30 1 600 $MIRROR_DOWNLOAD_PATH || exit $ERR_ARTIFACT_STREAMING_DOWNLOAD
  elif [ "$2" = "rpm" ]; then
    dnf_install 30 1 600 $MIRROR_DOWNLOAD_PATH || exit $ERR_ARTIFACT_STREAMING_DOWNLOAD
  fi
  rm $MIRROR_DOWNLOAD_PATH

You can also share your feedback on Copilot code review. Take the survey.

Comment thread vhdbuilder/packer/install-dependencies.sh Outdated
@djsly djsly changed the title feat: unblock artifact streaming for arm64 nodes feat: unblock artifact streaming for arm64 nodes and remove support on mariner Mar 19, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 15:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enable artifact streaming on ARM64 node pools by selecting ARM64-specific packages, bumping the mirror proxy version, and removing the deprecated AzLinux/Mariner 2.0 installation path.

Changes:

  • Append -arm64 to artifact streaming package name on ARM64 nodes.
  • Bump MIRROR_PROXY_VERSION to 0.3.1.
  • Remove artifact streaming install path for Mariner/Azure Linux 2.0; keep Azure Linux 3.0.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread vhdbuilder/packer/install-dependencies.sh Outdated
Comment thread vhdbuilder/packer/install-dependencies.sh Outdated
Comment thread vhdbuilder/packer/install-dependencies.sh Outdated

@SriHarsha001 SriHarsha001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to consider this small suggestion from AI about using "$PACKAGE_EXTENSION" instead of "$2".

@ganeshkumarashok ganeshkumarashok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend testing with Agentbaker e2e + test VHD before merging

@KananMehta KananMehta merged commit 5a6b409 into main Mar 19, 2026
29 checks passed
@KananMehta KananMehta deleted the kananmehta/artistreaming-arm64 branch March 19, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants