Skip to content

Conversation

@pauldotyu
Copy link
Contributor

Purpose

  • Deploy to Azure using azd up command
  • This deployment provisions all Azure infra using Terraform via Azure Developer CLI, replaces local RabbitMQ and MongoDB containers with Azure Service Bus and Azure CosmosDB, and deploys the app using a local Helm chart

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Open the repo in GitHub Codespace
  • Authenticate to Azure Developer CLI using azd auth login command
  • Authenticate to Azure CLI using az login command
  • Provision Azure resources and deploy app using azd up command

What to Check

Verify that the following are valid

  • In the Azure portal, use Azure Service Bus explorer to check for order messages
  • In the Azure portal, use the Azure Cosmos DB database explorer to check for order records
  • Port-forward the store-admin service and ensure you can add product descriptions using the AI service

Other Information

@pauldotyu pauldotyu requested a review from chzbrgr71 November 22, 2023 01:52
@chzbrgr71
Copy link
Collaborator

I tested the azd update and it all worked as expected. Awesome!

I would suggest one update on the README. Can you add a couple bullets on testing the deployment as described in the PR (see below).

Verify that the following are valid

In the Azure portal, use Azure Service Bus explorer to check for order messages
In the Azure portal, use the Azure Cosmos DB database explorer to check for order records
Port-forward the store-admin service and ensure you can add product descriptions using the AI service

@pauldotyu
Copy link
Contributor Author

I would suggest one update on the README. Can you add a couple bullets on testing the deployment as described in the PR (see below).

Verify that the following are valid

In the Azure portal, use Azure Service Bus explorer to check for order messages
In the Azure portal, use the Azure Cosmos DB database explorer to check for order records
Port-forward the store-admin service and ensure you can add product descriptions using the AI service

Thanks @chzbrgr71! I've updated the README.md file with the additional validation steps.

Copy link
Collaborator

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome

@chzbrgr71 chzbrgr71 merged commit bf526a0 into main Nov 27, 2023
@pauldotyu pauldotyu deleted the azd branch December 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants