Skip to content

Conversation

@ksubrmnn
Copy link
Contributor

Purpose

Add compatibility with Azure Service Mesh

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?
Adds manifests needed for aks-store-demo to work with Azure Service Mesh

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  1. Create cluster with ASM
  2. kubectl label namespace pets istio.io/rev=asm-1-17
  3. kubectl apply -f aks-store-quickstart.yaml
  4. kubectl apply -f manifests/istio/gateway.yaml
  5. Connect to store-front ExternalIP in browser
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Signed-off-by: Kalya Subramanian <[email protected]>
@chzbrgr71
Copy link
Collaborator

LGTM

Copy link
Collaborator

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@chzbrgr71 chzbrgr71 merged commit 845c893 into Azure-Samples:main Nov 19, 2023
@ksubrmnn ksubrmnn deleted the asm branch November 30, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants