Skip to content

Conversation

@huangyingting
Copy link
Contributor

Purpose

Fix insecure websocket for store-front and store-admin and remove tls requirement for mongodb from makeline-service* ...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

Fix insecure websocket for store-front and store-admin and remove tls requirement for mongodb from makeline-service
When deploy store-front and store-admin behind of nginx ingress with https, the default web dev server will start websocket because by default it is using ws, so insecure webclient error will reported.

For mongodb connection, also remove tls support

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@pauldotyu pauldotyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @huangyingting!

This all looks good and left some feedback on the changes to the mongodb.go file which needs to support both mongodb and Azure CosmosDB.

@pauldotyu
Copy link
Contributor

pauldotyu commented Oct 10, 2023

Fix in this PR will address: https://github.com/Azure-Samples/aks-store-demo/security/code-scanning/3 which is being tracked in #63

@pauldotyu pauldotyu self-requested a review December 5, 2023 22:53
@pauldotyu pauldotyu merged commit 84b2868 into Azure-Samples:main Dec 5, 2023
@pauldotyu
Copy link
Contributor

Sync'd forked branch and applied suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants