AKS store demo 2.0 #210

pauldotyu · 2025-04-10T18:02:09Z

Purpose

store-front upgrade to Vue 3.5 with Vite for better performance, route handling improvements, and some styling refinements
store-admin upgrade to Vue 3.5 with Vite for better performance, route handling improvements, and some styling refinements
ai-service replace Semantic Kernel with OpenAI SDK and container image optimization
makeline-service add workload identity support for Azure CosmosDB MongoDB API
Terraform refactor to use Azure Verified Modules (for most resources observability resources not published yet) and default to workload identity for all Azure services
Bicep refactor to use Azure Verified Modules (for most resources observability resources not published yet) and default to workload identity for all Azure services

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

github-actions · 2025-06-14T16:25:09Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 15653940319
Environment: e2etest
Location: australiaeast

github-actions · 2025-06-14T16:25:47Z

❌ @pauldotyu E2E tests failed!

Workflow Run: 15653940319
Status: Failed
Environment: e2etest
Location: australiaeast

Please check the workflow logs for details and try again.

pauldotyu · 2025-06-14T16:27:29Z

/test-e2e

github-actions · 2025-06-14T16:27:57Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 15653963559
Environment: e2etest
Location: australiaeast

github-actions · 2025-06-14T16:28:28Z

❌ @pauldotyu E2E tests failed!

Workflow Run: 15653963559
Status: Failed
Environment: e2etest
Location: australiaeast

Please check the workflow logs for details and try again.

pauldotyu · 2025-06-14T16:30:43Z

/test-e2e

github-actions · 2025-06-14T16:31:04Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 15653990181
Environment: e2etest
Location: australiaeast

github-actions · 2025-06-14T17:08:09Z

✅ @pauldotyu E2E tests completed successfully!

Workflow Run: 15653990181
Duration: ~37 minutes
Status: Passed
Environment: e2etest
Location: australiaeast

All tests passed and resources have been cleaned up.

Copilot

Pull Request Overview

This PR removes deprecated deployment hooks, updates Kubernetes manifests and environment variable definitions for services, adjusts default settings in the Makefile, and refreshes CI/CD workflows along with editor and container configurations.

Remove outdated azd hook scripts for post-provision and post-deploy steps
Bump RabbitMQ image version, reformat init container commands, and clean up obsolete service env vars
Update AI service env var definitions, Makefile defaults for AOAI model, and modernize GitHub workflows and editor settings

Reviewed Changes

Copilot reviewed 284 out of 284 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
azd-hooks/postprovision.sh	Removed deprecated Bash post-provision container build/import logic
azd-hooks/postprovision.ps1	Removed deprecated PowerShell post-provision container logic
azd-hooks/postdeploy.sh	Removed custom-values cleanup script
azd-hooks/postdeploy.ps1	Removed PowerShell custom-values cleanup
aks-store-quickstart.yaml	Bumped RabbitMQ image, reformatted initContainer command, removed VUE_APP env
aks-store-ingress-quickstart.yaml	Same RabbitMQ and initContainer updates, removed obsolete env vars
aks-store-all-in-one.yaml	Same RabbitMQ and initContainer updates, cleaned store-front/admin env
ai-service.yaml	Expanded and reordered OpenAI/LLM environment variable definitions
Makefile	Changed default region, replaced GPT-35 defaults with AOAI model vars
.vscode/settings.json	Added file nesting, format-on-save, and spell-check settings
.vscode/extensions.json	Recommended workspace extensions
.prettierrc.json	Added Prettier configuration
.github/workflows/test-playwright.yaml	Renamed workflow, updated checkout and login steps
.github/workflows/test-e2e.yaml	Added scheduled/test dispatch E2E workflow
.github/workflows/test-e2e-main.yaml	Composite workflow for main branch E2E testing
.github/workflows/audit-terraform.yml	Renamed scan job, bumped Trivy action and updated parameters
.github/workflows/audit-bicep.yml	Renamed scan job, switched to PSRule action and updated upload path
.devcontainer/devcontainer.json	Added more recommended VS Code extensions

Comments suppressed due to low confidence (3)

ai-service.yaml:33

The 'name' fields for AZURE_OPENAI_DALLE_ENDPOINT, AZURE_OPENAI_API_VERSION, AZURE_OPENAI_DALLE_DEPLOYMENT_NAME, and USE_LOCAL_LLM include trailing '=' characters. Remove '=' from the name and place defaults in the 'value' field to ensure valid env var keys.

            - name: AZURE_OPENAI_DALLE_ENDPOINT= # required if using Azure OpenAI DALL-E

.github/workflows/test-playwright.yaml:32

Add a step to install Playwright browsers (e.g., 'npx playwright install --with-deps') before running tests, otherwise test execution may fail due to missing browser binaries.

-        run: npx playwright test --config=playwright.service.config.ts --workers=20

.github/workflows/test-playwright.yaml:19

[nitpick] Consider using version tags (e.g., actions/checkout@v4) instead of a specific commit SHA to benefit from non-breaking updates and clearer intent.

-      - name: Checkout

pauldotyu · 2025-07-01T17:30:01Z

/test-e2e

github-actions · 2025-07-01T17:30:21Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 16006134059
Environment: e2etest
Location: australiaeast

github-actions · 2025-07-01T17:30:45Z

❌ @pauldotyu E2E tests failed!

Workflow Run: 16006134059
Status: Failed
Environment: e2etest
Location: australiaeast

Please check the workflow logs for details and try again.

pauldotyu · 2025-07-01T17:43:25Z

/test-e2e

github-actions · 2025-07-01T17:43:48Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 16006390452
Environment: e2etest
Location: australiaeast

github-actions · 2025-07-01T18:14:07Z

❌ @pauldotyu E2E tests failed!

Workflow Run: 16006390452
Status: Failed
Environment: e2etest
Location: australiaeast

Please check the workflow logs for details and try again.

pauldotyu · 2025-07-01T18:17:27Z

/test-e2e

github-actions · 2025-07-01T18:17:53Z

🚀 @pauldotyu Starting E2E tests...

Workflow Run: 16007054976
Environment: e2etest
Location: australiaeast

github-actions · 2025-07-01T18:52:36Z

✅ @pauldotyu E2E tests completed successfully!

Workflow Run: 16007054976
Duration: ~35 minutes
Status: Passed
Environment: e2etest
Location: australiaeast

All tests passed and resources have been cleaned up.

…ary for demo

…stent image builds

usepowershell

Great update (and thanks Copilot for the review help)

asw101 · 2025-07-08T23:32:04Z

LGTM!

pauldotyu force-pushed the main branch from f9024df to f332689 Compare May 2, 2025 03:38

pauldotyu force-pushed the main branch from ede3343 to 1916f94 Compare May 28, 2025 14:12

pauldotyu requested a review from Copilot May 28, 2025 17:13

This comment was marked as outdated.

Sign in to view

pauldotyu force-pushed the main branch 11 times, most recently from 5ebdf5a to 478d6ca Compare June 4, 2025 19:03

pauldotyu force-pushed the main branch 15 times, most recently from 8ee27fa to fd065ba Compare June 8, 2025 18:17

pauldotyu requested a review from Copilot June 14, 2025 17:11

Copilot AI reviewed Jun 14, 2025

View reviewed changes

fix(observability): update Grafana major version from 10 to 11

f55f6e6

pauldotyu added 3 commits July 8, 2025 15:06

fix(ps-rule): update comments to clarify log storage necessity for demo

693cedb

fix(trivyignore): update comment to clarify AKS logging is not necess…

72f3017

…ary for demo

fix(azure.yaml): update service languages from ts to docker for consi…

b3601d3

…stent image builds

asw101 self-assigned this Jul 8, 2025

pauldotyu assigned usepowershell and asw101 and unassigned asw101 Jul 8, 2025

usepowershell approved these changes Jul 8, 2025

View reviewed changes

pauldotyu merged commit 90c9108 into Azure-Samples:main Jul 9, 2025
13 checks passed

AKS store demo 2.0 #210

AKS store demo 2.0 #210

Uh oh!

Conversation

pauldotyu commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Does this introduce a breaking change?

Pull Request Type

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

pauldotyu commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

pauldotyu commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

github-actions bot commented Jun 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

pauldotyu commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

pauldotyu commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

pauldotyu commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

usepowershell left a comment

Choose a reason for hiding this comment

Uh oh!

asw101 commented Jul 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pauldotyu commented Apr 10, 2025 •

edited

Loading