Skip to content

Conversation

@zioproto
Copy link
Contributor

Copy link
Collaborator

@chzbrgr71 chzbrgr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chzbrgr71
Copy link
Collaborator

The file looks good, but can we make a couple minor changes:

  • Add a comment in the yaml to signal where this is being used.
  • Move the file into a subdirectory where we store other manifests. Use: /sample-manifests/docs/app-routing

We will be moving the other YAML files in the future.

@chzbrgr71 chzbrgr71 merged commit ee80a35 into Azure-Samples:main Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants