Skip to content

Conversation

@pauldotyu
Copy link
Contributor

@pauldotyu pauldotyu commented May 2, 2024

Purpose

  • Product image generation with OpenAI DALL-E model
  • Workload identity support for order-service and makeline-service
  • Misc bug fixes, code clean-up, and k8s manifest updates

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [email protected]:pauldotyu/aks-store-demo
cd aks-store-demo
  • Update azd manifest and Terraform output to point to pauldotyu repo
sed -i 's/azure-samples/pauldotyu/g' azure.yaml
sed -i 's/azure-samples/pauldotyu/g' infra/terraform/outputs.tf
  • Provision Azure resources
azd env new demo
azd env set DEPLOY_AZURE_WORKLOAD_IDENTITY true 
azd env set DEPLOY_AZURE_OPENAI true     
azd env set DEPLOY_AZURE_OPENAI_DALL_E_MODEL true       
azd env set DEPLOY_AZURE_SERVICE_BUS true       
azd env set DEPLOY_AZURE_COSMOSDB true          
azd env set DEPLOY_OBSERVABILITY_TOOLS true
azd up

Be sure to choose a location where you have DALL-E-3 availability; otherwise, unset the DEPLOY_AZURE_OPENAI_DALL_E_MODEL variable.

What to Check

Verify that the following are valid

  • Ensure all Azure PaaS resources (OpenAI, ServiceBus, and CosmosDB) have local auth disabled
  • Ensure User can generate product images in store-admin site

Other Information

@pauldotyu pauldotyu requested a review from usepowershell May 2, 2024 21:23
Copy link
Contributor

@usepowershell usepowershell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change and while it looks good, we really need to develop a good test harness - for each of the services in isolation as well as the various deployment options.

@pauldotyu pauldotyu merged commit bb0670f into Azure-Samples:main May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants