Skip to content

Comments

Adding an Ingress option#138

Merged
pauldotyu merged 3 commits intoAzure-Samples:mainfrom
sabbour:ingress
Apr 11, 2024
Merged

Adding an Ingress option#138
pauldotyu merged 3 commits intoAzure-Samples:mainfrom
sabbour:ingress

Conversation

@sabbour
Copy link
Contributor

@sabbour sabbour commented Apr 11, 2024

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@pauldotyu pauldotyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sabbour!

@pauldotyu pauldotyu merged commit fcad517 into Azure-Samples:main Apr 11, 2024
@sabbour sabbour deleted the ingress branch April 11, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants