Skip to content

Conversation

@pauldotyu
Copy link
Contributor

@pauldotyu pauldotyu commented Feb 9, 2024

Purpose

Publish helm package in ghcr

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@pauldotyu pauldotyu changed the title feat: publish helm chart to resolve #106 ci: publish helm chart to resolve #106 Feb 9, 2024
@pauldotyu pauldotyu marked this pull request as ready for review February 9, 2024 01:17
Copy link
Contributor

@usepowershell usepowershell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are publishing the helm chart as part of the release, it should also use the versions of the containers at the same version number.

@pauldotyu pauldotyu marked this pull request as draft February 9, 2024 01:29
@pauldotyu pauldotyu marked this pull request as ready for review February 9, 2024 18:12
@pauldotyu
Copy link
Contributor Author

If you are publishing the helm chart as part of the release, it should also use the versions of the containers at the same version number.

Broke out the helm package workflow to its own and pulling version from Chart.yaml.

@usepowershell usepowershell merged commit 702c6ad into main Feb 9, 2024
@pauldotyu pauldotyu deleted the publish_helm branch February 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants