Add Bicep support to aks-store-demo #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @dotnet-7. We've just merged in some pretty significant changes to the Terraform templates in PR #96 and PR #104 so there might be some additional resources that need to be added to the Bicep (i.e., ACR and onboarding the AKS cluster to Container Insights and managed Prometheus with managed Grafana). I'll help get conflicts resolved and up to date with latest then review the PR. |
Author
|
@pauldotyu, @jongio - We have resolved the conflicts. PR is ready, please review. Thanks! |
- make azd-hook scripts executable - adding predeploy to bicep deployment - remove k8s version and use aks default instead - fix acrpull for kublet identity - fix cosmos db account kind parameters - add overwrite existing param for az aks get creds
Contributor
|
This resolves #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bicep support to aks-store-demo.
The reason why keyvault is not used in the code to get keys:
Because the source code to deploy is in the remote images, we cannot directly modify the local code to read key from keyvault. Therefore, we added a command to use 'az' to obtain the keys from the keyvault in the file
azd-hooks/postprovision.sh.The reason why update
openai_model_capacityfrom 120 to 30:The capacity of the current OpenAi model is 120 and is too huge for most of the avaliable locations, so we change it to 30 temporarily like other templates.
@jongio for notification.