Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 10, 2024
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
4c99c3d to
d158b08
Compare
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
fc15d18 to
b57b5e9
Compare
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
d158b08 to
62c4e45
Compare
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
b57b5e9 to
060057e
Compare
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
62c4e45 to
da0ecb5
Compare
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
060057e to
ee830d6
Compare
IlyasRidhuan
changed the title
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
da0ecb5 to
13e10c1
Compare
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
ee830d6 to
5fe6ae7
Compare
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
13e10c1 to
d9eecce
Compare
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
5fe6ae7 to
1dad3c0
Compare
dbanks12
approved these changes
Nov 14, 2024
IlyasRidhuan
force-pushed
the
ir/11-03-feat_avm_ephmeral_avm_tree
branch
from
d9eecce to
f152568
Compare
Base automatically changed from
ir/11-03-feat_avm_ephmeral_avm_tree
to
master
November 18, 2024 17:56
IlyasRidhuan
force-pushed
the
ir/11-10-perf_avm_minor_benchmarking
branch
from
1dad3c0 to
1c90919
Compare
TomAFrench
added a commit
that referenced
this pull request
Nov 19, 2024
* master: (67 commits) chore: Fix bad merge on AztecLMDBStore initializer feat: add persisted database of proving jobs (#9942) chore: Clean up data configuration (#9973) chore: remove public kernels (#10027) chore: misc cleanup, docs and renaming (#9968) feat: IPA Accumulator in Builder (#9846) chore(docs): Updates to token contract (#9954) test(avm): minor benchmarking (#9869) chore(ci): run `l1-contracts` CI in parallel with `build` step (#10024) chore: build acir test programs in parallel to e2e build step (#9988) chore: pull out `array_set` pass changes (#9993) feat(avm): ephemeral avm tree (#9798) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a very small micro-benchmark for the a future PR to reference.
This sets up the smallest "worst-case" scenario for the current ephmeral tree implementation.
indexedTreeMin.a) The DB reads occur because the ephemeral tree doesnt track slots 1 to 127
b) All reads are O(n) as we traverse from min leaf to the low leaf info