fix: deploy l2 contracts fails on 48 validator#9860
Merged
Conversation
just-mitch
changed the title
just-mitch
added
the
hotfix
Contributor
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
ludamad
approved these changes
Nov 9, 2024
ludamad
reviewed
Nov 11, 2024
| await provenTx.send().wait(waitOpts); | ||
| log('setupCanonicalL2FeeJuice: Fee juice contract initialized'); | ||
| } catch (e: any) { | ||
| if (e instanceof Error && e.message.includes('(method pxe_simulateTx) (code 400) Assertion failed')) { |
Collaborator
There was a problem hiding this comment.
Noting that this looks almost guaranteed to churn at some point (method name change, format change etc)
Collaborator
There was a problem hiding this comment.
correct solution would be maybe 204 error code for this case
ludamad
deleted the
9822-bug-deploy-l2-contracts-fails-on-48-validator
branch
Contributor
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
ludamad
added a commit
that referenced
this pull request
Nov 11, 2024
This was sometimes erroring out on the first attempt while awaiting the transaction to settle, but then subsequent calls were attempting to reinitialize. Added better logging to help clarify. Also adjust the validator url in the template to be the top level service, to better distribute transactions across the network and not rely so heavily on the boot node for gossiping. --------- Co-authored-by: ludamad <[email protected]>
ludamad
added a commit
that referenced
this pull request
Nov 11, 2024
TomAFrench
added a commit
that referenced
this pull request
Nov 11, 2024
* master: (182 commits) feat(avm): mem specific range check (#9828) refactor: remove public kernel inner (#9865) chore: Revert "chore: Validate RPC inputs" (#9875) Revert "fix: deploy l2 contracts fails on 48 validator" (#9871) fix: deploy l2 contracts fails on 48 validator (#9860) chore: Validate RPC inputs (#9672) fix: fixing devcontainers to use the sandbox docker-compose file (#9782) fix: Revert changes to ci.yml (#9863) chore: Move epoch and slot durations to config (#9861) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: tree heights that last past 3 days (#9760) fix(build): l1-contracts .rebuild_patterns did not cover test files (#9862) fix: bench prover test (#9856) fix: Fix mac build by calling `count` on durations (#9855) feat: zk shplemini (#9830) feat: domain separate block proposals and attestations (#9842) chore: bump runner cache disk size (#9849) ...
just-mitch
removed
the
hotfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was sometimes erroring out on the first attempt while awaiting the transaction to settle,
but then subsequent calls were attempting to reinitialize.
Added better logging to help clarify.
Also adjust the validator url in the template to be the top level service, to better distribute transactions across the network and not rely so heavily on the boot node for gossiping.