chore!: Remove recursive from ACIR format; add them to API and CLI#9479
Merged
TomAFrench merged 66 commits intomasterfrom Nov 1, 2024
Merged
chore!: Remove recursive from ACIR format; add them to API and CLI#9479TomAFrench merged 66 commits intomasterfrom
recursive from ACIR format; add them to API and CLI#9479TomAFrench merged 66 commits intomasterfrom
Conversation
recursive from ACIR format; add them to API and CLIrecursive from ACIR format; add them to API and CLI (DRAFT)
0174639 to
e0f0fe7
Compare
TomAFrench
reviewed
Oct 28, 2024
recursive from ACIR format; add them to API and CLI (DRAFT)recursive from ACIR format; add them to API and CLI
Member
I think yes as we could want to test recursive proof generation (these methods are mostly used for our CI) |
5bda036 to
b57695c
Compare
TomAFrench
reviewed
Nov 1, 2024
Member
TomAFrench
left a comment
There was a problem hiding this comment.
Just need to re-add recursive testing for assert_statement. We should be good to go after this.
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
…ec-packages into 6185-rm-recursive-attr
TomAFrench
approved these changes
Nov 1, 2024
Member
|
Looks like there's a bash issue with adding the recursive flag to the CLI args. |
…ec-packages into 6185-rm-recursive-attr
…ec-packages into 6185-rm-recursive-attr
c5e4c46 to
0e38181
Compare
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves noir-lang/noir#6185
recursivefield from ACIR formats and theCircuitdefinition--recursivetobbCLIrecursivetomain.ts, the backend API and WasmThis is effectively undoing a lot of what was done here. Interestingly there many more Wasm methods that need the
recursiveparameter now: whereas previously onlyacir_create_proofandacir_verify_proofused it, now anything that callscreate_circuitneeds it because circuit creation builds all the constraints already, which depend on this.TODO:
#[recursive]attribute from Noir#[recursive]fromnoir-protocol-circuitsbb-proverwhere it uses usesnoir-protocol-circuitsto use the correctrecursiveflag--recursivetocli.tsunderbb-proverexecuteBBand pass--recursiveif it calls abbcommand that needs it