Skip to content

fix: spot_strategy passing #9428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludamad merged 10 commits into from
Oct 25, 2024
Merged

fix: spot_strategy passing #9428

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cb173e2
Update action.yml
ludamad Oct 25, 2024
760fe9c
Update action.yml
ludamad Oct 25, 2024
82e9c56
Update action.yml
ludamad Oct 25, 2024
da2fbb7
Allow 4epochs to fail true
ludamad Oct 25, 2024
0e2ba2a
Update ci.yml
ludamad Oct 25, 2024
36c0d1c
try diff kill patern
ludamad Oct 25, 2024
2121b90
try another approach
ludamad Oct 25, 2024
ae41702
size fix
ludamad Oct 25, 2024
3f62f5f
Update ci.yml
ludamad Oct 25, 2024
b35b144
Merge branch 'master' into ad/fix-spot-strategy
ludamad Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/ensure-tester-with-images/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ description: "Reusable setup steps"
inputs:
runner_type:
required: true
spot_strategy:
default: BestEffort
builder_type:
required: true
builder_images_to_copy:
Expand Down Expand Up @@ -59,6 +61,7 @@ runs:
if: ${{ env.CACHE_SUCCESS != 'true' }}
with:
runner_type: ${{ inputs.runner_type}}
spot_strategy: ${{ inputs.spot_strategy }}
ttl: ${{ inputs.tester_ttl }}
run: |
set -eux
Expand Down
5 changes: 3 additions & 2 deletions .github/ensure-tester/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,12 @@ inputs:
run:
# command to run once tester available
required: false

ttl:
required: false
description: "Time to live for the tester instance in minutes"
default: 30
spot_strategy:
default: BestEffort
runs:
# define an action, runs in OS of caller
using: composite
Expand All @@ -23,7 +24,7 @@ runs:
run: |
TYPE=${{ inputs.runner_type }}
# Try to use spot for every runner type for now
echo "spot_strategy=BestEffort" >> $GITHUB_OUTPUT
echo "spot_strategy=${{ inputs.spot_strategy }}" >> $GITHUB_OUTPUT
echo "runner_label=$USERNAME-$runner_type" >> $GITHUB_OUTPUT
echo "ami_id=ami-04d8422a9ba4de80f" >> $GITHUB_OUTPUT
# no github runners, 'bare spot' in action code
Expand Down