feat(avm): use template engine for codegen

[fcarreiro]

Generating flavor file as an example.

[fcarreiro]

• feat(avm): use template engine for codegen #7299 👈
• chore(avm): basic stat collection #7283
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[Maddiaa0]

much better

[jeanmon]

This template language looks very readable to me. I would continue to commit the generated cpp files though. This is very security sensitive and I would prefer not to depend on such a template library in a blind way.

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 537 (+777%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 58.3 (-67%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 1,319 (+21%)
• l2_block_processing_time_in_ms (4): 757 (-60%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,758 (+1%)	1,559 (+1%)	710	754 (+1%)	779 (+1%)
proof_construction_time_sha256_30_ms	11,926 (+2%)	3,167 (+1%)	1,410	1,428	1,472
proof_construction_time_sha256_100_ms	44,118 (+1%)	11,815 (+1%)	5,429	5,407	5,364
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0 (-3%)	58.0	87.0
proof_construction_time_poseidon_hash_30_ms	1,525 (+1%)	420 (+1%)	202 (+1%)	225 (+1%)	267 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,796 (+1%)	1,578 (+1%)	722	782	796

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,468	9,476
l1_rollup_execution_gas	611,203	611,358	611,517
l2_block_processing_time_in_ms	⚠️ 757 (-60%)	1,409 (-10%)	2,711
l2_block_building_time_in_ms	20,901 (+1%)	42,492 (-6%)	81,719
l2_block_rollup_simulation_time_in_ms	20,900 (+1%)	42,491 (-6%)	81,718
l2_block_public_tx_process_time_in_ms	17,894 (+1%)	39,243 (-6%)	78,546

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,035 (-3%)	9,810 (-12%)
node_database_size_in_bytes	12,251,216	16,138,320
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	103	388 (-1%)	12,485 (-3%)	19,482	54,134	73,920	2,243	524,288
private-kernel-inner	311 (-1%)	775 (-7%)	51,398 (-1%)	80,694	54,134	73,920	2,243	2,097,152
private-kernel-tail	1,092 (-3%)	2,704 (+5%)	49,705 (-3%)	61,457	62,057	14,912	399	2,097,152
base-parity	6.13 (-5%)	1,629 (+5%)	2,637 (-1%)	128	64.0	2,208	2.00	131,072
root-parity	49.4 (-2%)	67.0 (+3%)	40,898 (-4%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	6,655 (-3%)	4,894	91,844 (+1%)	170,330	728	3,648	47.0	4,194,304
root-rollup	111	80.7 (+2%)	23,935 (-2%)	25,253	620	3,456	41.0	1,048,576
public-kernel-setup	547 (+1%)	2,426	42,204	102,121	80,278	106,912	3,274	2,097,152
public-kernel-app-logic	508 (-2%)	3,383 (-1%)	45,989 (+5%)	102,121	80,278	106,912	3,274	2,097,152
public-kernel-tail	1,161 (-4%)	26,586 (-4%)	180,204 (-5%)	399,014	10,014	14,912	399	8,388,608
private-kernel-reset-small	469 (-3%)	⚠️ 1,319 (+21%)	31,492	109,233	54,134	73,920	2,243	1,048,576
public-kernel-teardown	497 (+1%)	3,415 (-1%)	43,467 (-1%)	102,121	80,278	106,912	3,274	2,097,152
merge-rollup	29.7 (-1%)	N/A	N/A	16,486	728	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,659 (+2%)	51,548 (-6%)	N/A	N/A	106,912	3,274	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	8,792	411 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	8,792	38.8 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	8,792	1,194	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	8,792	902	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	8,792	491	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	8,792	1,627 (-4%)	14,720	54,234 (+1%)	2,097,152	393
Token:privately_mint_private_note	1,280	8,792	626 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	8,792	274	14,720	11,627 (+1%)	524,288	393
Token:transfer	1,312	8,792	1,811 (+2%)	14,720	13,137 (+5%)	524,288	393
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,269 (-6%)	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,784 (-5%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,776 (-4%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,753 (-2%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	24,164 (+2%)	N/A	N/A
Benchmarking:create_note	1,344	8,792	480 (-5%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	8,792	71.4	N/A	N/A	N/A	N/A
Token:unshield	1,376	8,792	1,525 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	8,792	2,112 (+1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	67.5	13,790
GasToken:set_portal	16.9 (-27%)	3,339
Token:constructor	94.5 (+4%)	23,692
FPC:constructor	65.0 (+1%)	13,592
GasToken:mint_public	51.3	10,158
Token:mint_public	⚠️ 537 (+777%)	19,034
Token:assert_minter_and_mint	⚠️ 58.3 (-67%)	12,925
AuthRegistry:set_authorized	33.5 (-1%)	7,812
FPC:prepare_fee	111 (+2%)	15,062
Token:transfer_public	48.5 (-25%)	31,218
FPC:pay_refund	133 (-2%)	25,260
Benchmarking:increment_balance	2,222 (-3%)	15,267
Token:_increase_public_balance	55.6	15,006
FPC:pay_refund_with_shielded_rebate	117 (+2%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.163 (+5%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4 (-1%)	16.7 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599 (-1%)	0.514 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.2 (-2%)	75.4 (-1%)	131	245 (-9%)	470
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.492 (-2%)	0.464 (-1%)	0.450	0.443 (-9%)	0.439
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.1 (-1%)	111 (-1%)	182	355 (-11%)	693
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.508 (-1%)	0.499 (-1%)	0.482	0.481 (-12%)	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.7 (-4%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.518 (-4%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,057	667,850

Transaction size based on fee payment method

| Metric | |
| - | |

[fcarreiro]

Merge activity

• Jul 3, 10:34 AM EDT: @fcarreiro started a stack merge that includes this pull request via Graphite.
• Jul 3, 10:36 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 3, 11:14 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'merge-check', 'noir-projects', 'boxes').

[AztecBot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: 9fab71f	Previous: d42812e	Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20	5219.444651999993 ms/iter	4759.664720999993 ms/iter	1.10

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton