Skip to content

chore: redo typo PR by dufucun#6822

Merged
ludamad merged 2 commits intomasterfrom
chore/typo-redo-6820
Jun 3, 2024
Merged

chore: redo typo PR by dufucun#6822
ludamad merged 2 commits intomasterfrom
chore/typo-redo-6820

Conversation

@ludamad
Copy link
Copy Markdown
Collaborator

@ludamad ludamad commented Jun 3, 2024

Thanks dufucun for #6820. Our policy is to redo typo changes to dissuade metric farming. This is an automated script.

AztecBot and others added 2 commits June 3, 2024 09:08
@ludamad ludamad force-pushed the chore/typo-redo-6820 branch from 04054af to cf427b6 Compare June 3, 2024 09:10

# Step 5: Close the original PR
echo "Closing original PR #$ORIGINAL_PR_NUMBER"
gh pr close $ORIGINAL_PR_NUMBER --delete-branch
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundled - this deleted my local master branch, but not the user branch as it was master

@ludamad ludamad requested a review from TomAFrench June 3, 2024 09:11
@AztecBot
Copy link
Copy Markdown
Collaborator

AztecBot commented Jun 3, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://665d8cfc8484c03537e4589e--aztec-docs-dev.netlify.app

@ludamad ludamad enabled auto-merge (squash) June 3, 2024 09:31
@AztecBot
Copy link
Copy Markdown
Collaborator

AztecBot commented Jun 3, 2024

Benchmark results

Metrics with a significant change:

  • proof_construction_time_poseidon_hash_100_ms (16): 938 (+29%)
  • proof_construction_time_poseidon_hash_30_ms (16): 281 (+38%)
  • proof_construction_time_poseidon_hash_30_ms (32): 265 (+17%)
  • proof_construction_time_sha256_ms (16): 916 (+30%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 1,170 (+21%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,703 (-2%) 1,542 (-2%) ⚠️ 916 (+30%) 847 (+11%) 818 (+5%)
proof_construction_time_sha256_30_ms 11,798 (-2%) 3,128 (-2%) 1,402 (-1%) 1,422 (-1%) 1,446 (-2%)
proof_construction_time_sha256_100_ms 44,596 (-2%) 11,990 (-2%) 5,644 5,545 5,501
proof_construction_time_poseidon_hash_ms 78.0 (-1%) 34.0 43.0 (+26%) 65.0 (+12%) 92.0 (+5%)
proof_construction_time_poseidon_hash_30_ms 1,514 (-2%) 417 (-2%) ⚠️ 281 (+38%) ⚠️ 265 (+17%) 289 (+7%)
proof_construction_time_poseidon_hash_100_ms 5,721 (-2%) 1,561 (-1%) ⚠️ 938 (+29%) 868 (+11%) 839 (+4%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,452 9,464 9,476
l1_rollup_execution_gas 607,988 608,000 608,012
l2_block_processing_time_in_ms 1,303 (+3%) 4,816 (+3%) 9,603 (+3%)
l2_block_building_time_in_ms 45,039 (+4%) 177,894 (+4%) 355,214 (+4%)
l2_block_rollup_simulation_time_in_ms 44,824 (+4%) 177,173 (+4%) 353,790 (+4%)
l2_block_public_tx_process_time_in_ms 41,529 (+4%) 173,792 (+4%) 350,358 (+4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 9,396 (-2%) 14,385 (-1%)
node_database_size_in_bytes 14,454,864 21,373,008
pxe_database_size_in_bytes 18,071 29,868

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 141 (+5%) 460 (-1%) 12,762 20,634 64,614 89,536 2,731 524,288
private-kernel-inner 419 (+4%) ⚠️ 1,170 (+21%) 50,793 (+2%) 92,326 64,614 89,536 2,731 2,097,152
private-kernel-tail 595 (+3%) 2,630 50,634 (-5%) 96,545 77,732 11,648 297 2,097,152
base-parity 6.43 1,691 (-2%) 2,697 128 64.0 2,208 2.00 131,072
root-parity 49.9 (+1%) 66.1 (+2%) 41,306 (-1%) 27,100 64.0 2,720 18.0 2,097,152
base-rollup 12,143 (+2%) 2,388 (-2%) 78,174 (+2%) 119,738 756 3,648 47.0 4,194,304
root-rollup 111 (+2%) 75.6 (-3%) 23,097 (-7%) 25,309 620 3,456 41.0 1,048,576
public-kernel-app-logic 577 (+2%) 3,494 (-2%) 44,682 (+1%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-tail 1,147 (+3%) 24,833 (+11%) 181,326 (-1%) 403,238 7,646 11,648 297 8,388,608
private-kernel-reset-small 600 (+3%) 1,922 (-14%) 45,600 120,737 64,614 89,536 2,731 2,097,152
public-kernel-setup 663 (-1%) 2,718 (-2%) 45,079 (+5%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-teardown 571 (-1%) 3,529 47,466 (+1%) 108,073 86,550 116,768 3,582 2,097,152
merge-rollup 29.0 (+1%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 9,240 (+11%) 100,424 (-1%) N/A N/A 116,768 3,582 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 460 (-2%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 40.9 (-1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,783 (+2%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,459 (+3%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,740 (+1%) 16,768 53,047 (-1%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,553 (-1%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 1,016 (-1%) 16,768 10,819 (-1%) 524,288 457
Token:transfer 1,376 9,944 5,333 (+1%) 16,768 52,397 2,097,152 457
Benchmarking:create_note 1,344 9,944 1,391 (+1%) N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 78.0 (+1%) N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,978 (+2%) N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,839 (+1%) N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 17.2 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.601 0.516 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.4 77.2 (+2%) 250 (+2%) 473 (-1%) 933 (+3%) 1,856 (+3%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.494 0.476 (+2%) 0.453 (+2%) 0.442 (-1%) 0.442 (+3%) 0.442 (+3%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 58.1 (+1%) 113 (+2%) 357 (+2%) 696 (-1%) 1,392 (+3%) 2,782 (+3%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.502 (+1%) 0.505 (+1%) 0.484 (+2%) 0.478 (-1%) 0.481 (+3%) 0.483 (+3%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 62.6 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 107
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.553 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 84,053 665,267

Transaction size based on fee payment method

| Metric | |
| - | |

@ludamad ludamad merged commit 6bd94ff into master Jun 3, 2024
@ludamad ludamad deleted the chore/typo-redo-6820 branch June 3, 2024 10:15
Maddiaa0 pushed a commit that referenced this pull request Jun 5, 2024
Thanks dufucun for
#6820. Our policy is
to redo typo changes to dissuade metric farming. This is an automated
script.

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Maddiaa0 pushed a commit that referenced this pull request Jun 5, 2024
Thanks dufucun for
#6820. Our policy is
to redo typo changes to dissuade metric farming. This is an automated
script.

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants