-
Notifications
You must be signed in to change notification settings - Fork 595
chore!: remove backend interactions from nargo
#6320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a22d895
chore: add example script to generate a verifier contract
TomAFrench 96b58f7
chore!: remove `codegen-verifier` command
TomAFrench 8e6c37a
chore: update docs
TomAFrench 37b68b1
Update noir/noir-repo/examples/codegen-verifier/codegen_verifier.sh
TomAFrench 836b861
chore: update integration tests to call `bb` directly
TomAFrench 75e4dd4
chore: update usage to handle bb.js
TomAFrench 9ccef03
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench b08729d
chore: add simple docs for installing `bb`
TomAFrench adc693c
chore: fix codegen-verifiers.sh
TomAFrench 1a0c641
chore: installs `bb` for noir CI
TomAFrench 4cf2403
Update noir/noir-repo/examples/codegen-verifier/codegen_verifier.sh
TomAFrench b44d4b4
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench 45783d7
feat: extend example to show how
TomAFrench 1270e1b
pull over some more files
TomAFrench 25dbbeb
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench 0016c8d
chore: add `examples` target to CI
TomAFrench 898cf57
chore: update test
TomAFrench fe3cfc7
chore: remove contract.sol
TomAFrench 1d8acfe
chore(ci): dont look for tags if pure spot (#6446)
ludamad 1962ead
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench 76b7b59
Update noir/noir-repo/examples/codegen-verifier/codegen_verifier.sh
TomAFrench eadaa0d
chore!: remove `nargo prove` and `nargo verify` (#6321)
TomAFrench 7dcc7da
feat!: remove backend interactions from `nargo` (#6369)
TomAFrench 4a99019
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench fdcb0d8
Update noir/noir-repo/docs/docs/how_to/how-to-solidity-verifier.md
TomAFrench 999e333
chore: remove dead code
TomAFrench 9ac2ed1
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench 12691b4
Merge branch 'master' into tf/remove-codegen-verifier
TomAFrench 7fab767
fmt
TomAFrench 435ab31
chore: update docs to reflect lack of `Verifier.toml` file
TomAFrench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [package] | ||
| name = "hello_world" | ||
| type = "bin" | ||
| authors = [""] | ||
| compiler_version = ">=0.29.0" | ||
|
|
||
| [dependencies] |
10 changes: 10 additions & 0 deletions
10
noir/noir-repo/examples/codegen-verifier/codegen_verifier.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/bin/bash | ||
| set -eu | ||
|
|
||
| BACKEND=${BACKEND:-bb} | ||
|
|
||
| nargo compile | ||
|
|
||
| # TODO: backend should automatically generate vk if necessary. | ||
| $BACKEND write_vk -b ./target/hello_world.json | ||
| $BACKEND contract -v ./target/vk | ||
|
TomAFrench marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| fn main(x: Field, y: pub Field) { | ||
| assert(x != y); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/bin/bash | ||
| set -eu | ||
|
|
||
| # This file is used for Noir CI and is not required. | ||
|
|
||
| BACKEND=${BACKEND:-bb} | ||
|
|
||
| ./codegen_verifier.sh | ||
|
|
||
| if ! [ -f ./target/contract.sol ]; then | ||
| printf '%s\n' "Contract not written to file" >&2 | ||
| exit 1 | ||
| fi |
71 changes: 0 additions & 71 deletions
71
noir/noir-repo/tooling/backend_interface/src/cli/contract.rs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 0 additions & 55 deletions
55
noir/noir-repo/tooling/backend_interface/src/smart_contract.rs
This file was deleted.
Oops, something went wrong.
21 changes: 0 additions & 21 deletions
21
noir/noir-repo/tooling/backend_interface/test-binaries/mock_backend/src/contract_cmd.rs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 0 additions & 68 deletions
68
noir/noir-repo/tooling/nargo_cli/src/cli/codegen_verifier_cmd.rs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.