chore!: remove Opcode::Brillig from ACIR

[TomAFrench]

This PR removes Opcode::Brillig as it has been superceded by Opcode::BrilligCall

[TomAFrench]

I've cut some corners related to the ACVM's interface as this is handled in noir-lang/noir#4897.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 73.2 (+143%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,832	6,832	6,844 (+1%)
l1_rollup_execution_gas	587,313	587,313	587,325
l2_block_processing_time_in_ms	1,466 (+1%)	5,348 (-1%)	10,393 (-1%)
note_successful_decrypting_time_in_ms	181 (-26%)	621 (+6%)	1,044 (-4%)
note_trial_decrypting_time_in_ms	⚠️ 73.2 (+143%)	23.9 (-71%)	122 (-15%)
l2_block_building_time_in_ms	18,730	72,842 (-1%)	145,137 (-1%)
l2_block_rollup_simulation_time_in_ms	18,515	72,079 (-1%)	143,638 (-1%)
l2_block_public_tx_process_time_in_ms	8,449 (-1%)	33,069 (-1%)	65,958 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,705 (+7%)	30,213
note_history_successful_decrypting_time_in_ms	1,453 (+7%)	2,750 (+1%)
note_history_trial_decrypting_time_in_ms	105 (+8%)	121 (-18%)
node_database_size_in_bytes	19,181,648	35,872,848
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	156	47,763	31,978
private-kernel-inner	177 (-1%)	80,794	31,978
private-kernel-ordering	137 (-1%)	57,732	50,043
base-parity	74.1 (-5%)	128	265
root-parity	123 (-5%)	1,244	265
base-rollup	12,192	110,926	957
root-rollup	49.9	4,551	821
public-kernel-app-logic	1,649 (-1%)	62,017	52,067
public-kernel-tail	4,201 (-1%)	168,566	7,491
merge-rollup	3,114 (-2%)	2,760	957
public-kernel-teardown	117 (-2%)	62,017	52,067
public-kernel-setup	118	62,017	52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.1 (+1%)	17.8 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.642 (+1%)	0.550 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.7 (-1%)	80.8	260	503	981	1,948	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.530 (-1%)	0.497	0.474	0.469	0.466	0.466	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.6	120 (+1%)	377 (+1%)	746 (+1%)	1,462	2,908 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.534	0.540 (+1%)	0.511	0.511	0.508	0.507 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.8
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.589

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	51,411	543,524

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,261 (-1%)	873 (+1%)	3,514

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	833 (-1%)	761	1,353	903	2,075	1,087 (-1%)

[TomAFrench]

This is now ready go in but we're going to do another sync between repos before merging.

[jfecher]

Can you mark the remaining work a bit more explicitly with TODOs or similar? They look like they'd be hard to find after the fact at the moment.

Edit: Cross-referenced the debugger PR and resolved my comments related to unimplemented work from there. I originally thought we'd come back later to fix it so TODOs would be useful but if we already have the code then it should be fine.

[vezenovm]

This is now ready go in but we're going to do another sync between repos before merging.

Maybe we should wait for noir-lang/noir#4897 to be merged and syncd with this repo before merging this PR

[jfecher]

👍