feat(acir)!: Program and witness stack structure#5149
Merged
TomAFrench merged 160 commits intomasterfrom Mar 19, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the breaking serialization outlined in this issue: noir-lang/noir#4428.
The line count is high, however, most of the changes in this PR are serialization changes due to our current structures of
CircuitandWitnessMapnow being contained within wrapper structures. Barretenberg now expects aProgramand aWitnessStack.For now Barretenberg expects that all functions are still inlined and we only work with a single circuit. This PR simply introduces the breaking serialization change for visibility and record keeping sake.