fix: Start witness of ACIR generated by Noir start at zero not one

[vezenovm]

Resolves noir-lang/noir#130
Only partially resovles AztecProtocol/barretenberg#816. There is some places like in serialize_arithmetic_gate where we assume that the zero_idx == 0.

BEGIN_COMMIT_OVERRIDE
fix!: Start witness of ACIR generated by Noir start at zero not one (#3961)
END_COMMIT_OVERRIDE

[TomAFrench]

Made a PR which shows the test failures more clearly by working around the jest issue.

#4006

jestjs/jest#11617

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit e28a6bf1 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	221,004	866,228	3,446,288
l1_rollup_execution_gas	934,148	3,968,702	24,789,824
l2_block_processing_time_in_ms	1,501	5,111	20,405 (-4%)
note_successful_decrypting_time_in_ms	310	929 (+1%)	3,364 (-1%)
note_trial_decrypting_time_in_ms	19.9 (-14%)	54.3 (+10%)	141 (+4%)
l2_block_building_time_in_ms	14,936	59,201	237,730
l2_block_rollup_simulation_time_in_ms	10,550 (+1%)	41,890	168,625
l2_block_public_tx_process_time_in_ms	4,355	17,238	68,835

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,927 (-1%)	28,643
note_history_successful_decrypting_time_in_ms	2,177	4,242 (-2%)
note_history_trial_decrypting_time_in_ms	109 (-6%)	158 (-7%)
node_database_size_in_bytes	3,622,512	3,727,698
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	213	44,681	25,561
private-kernel-ordering	165	43,753	14,809
base-rollup	1,067	128,338	881
root-rollup	78.8 (-2%)	4,088	677
private-kernel-inner	291	71,208	25,561
public-kernel-private-input	205	31,863	25,561
public-kernel-non-first-iteration	203	31,905	25,561
merge-rollup	7.60 (-9%)	2,608	881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_ms	11.1 (-2%)	16.3 (-6%)	14.8 (+3%)	17.7 (-1%)	23.5 (-1%)	50.0 (-2%)	76.6 (-7%)	242	471	909	3,540 (-1%)
batch_insert_into_indexed_tree_ms	N/A	N/A	N/A	63.7 (-1%)	N/A	59.2	110 (-1%)	364 (+1%)	733	1,408	5,539 (-1%)

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	15,455	32,219

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	373 (-1%)	1,082

Metric	1 public data writes
tx_sequencer_processing_time_ms	535

[ledwards2225]

LGTM. Really glad we're getting this in - looks like it was pretty deeply embedded. Thanks @TomAFrench for helping get it over the line!