Skip to content

fix: reject VK with log_circuit_size=0 in UltraKeccak verifier #22319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AztecBot wants to merge 2 commits into
base: merge-train/barretenberg
Choose a base branch
from
+5 −1
Open

fix: reject VK with log_circuit_size=0 in UltraKeccak verifier #22319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4e3dde
fix: reject VK with log_circuit_size=0 in UltraKeccak verifier
AztecBot Apr 4, 2026
0f228ea
Update ultra_verifier.cpp
ludamad Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions barretenberg/cpp/src/barretenberg/transcript/transcript.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ template <typename Codec_, typename HashFunction_> class BaseTranscript {
template <typename ChallengeType>
std::vector<ChallengeType> get_dyadic_powers_of_challenge(const std::string& label, size_t num_challenges)
{
BB_ASSERT(num_challenges > 0, "get_dyadic_powers_of_challenge called with num_challenges=0");
ChallengeType challenge = get_challenge<ChallengeType>(label);
std::vector<ChallengeType> pows(num_challenges);
pows[0] = challenge;
Expand Down
5 changes: 4 additions & 1 deletion barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ template <typename Flavor, class IO> size_t UltraVerifier_<Flavor, IO>::compute_
return static_cast<size_t>(Flavor::VIRTUAL_LOG_N);
} else {
// Non-padded: use actual circuit size from VK (native only)
return static_cast<size_t>(verifier_instance->get_vk()->log_circuit_size);
const size_t log_circuit_size = static_cast<size_t>(verifier_instance->get_vk()->log_circuit_size);
BB_ASSERT_GTE(
log_circuit_size, static_cast<size_t>(1), "VK log_circuit_size is 0, which is invalid for any circuit");
return log_circuit_size;
}
}

Expand Down
Loading