chore(alpha-testnet)!: apply version -> rollup_version#13180
Merged
Maddiaa0 merged 3 commits intoalpha-testnetfrom Apr 1, 2025
Merged
chore(alpha-testnet)!: apply version -> rollup_version#13180Maddiaa0 merged 3 commits intoalpha-testnetfrom
Maddiaa0 merged 3 commits intoalpha-testnetfrom
Conversation
Maddiaa0
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
Maddiaa0
changed the title
Maddiaa0
changed the title
spalladino
approved these changes
Mar 31, 2025
| curl -s -X POST -H 'content-type: application/json' \ | ||
| -d '{"jsonrpc":"2.0","method":"pxe_getNodeInfo","params":[],"id":67}' \ | ||
| 127.0.0.1:{{ .Values.pxe.service.nodePort }} | grep -q '"protocolVersion":1' | ||
| 127.0.0.1:{{ .Values.pxe.service.nodePort }} | grep -q '"rollupVersion":1' |
Contributor
There was a problem hiding this comment.
I've just realised: isn't this readiness probe going to cause the pxe to always be flagged as fail if we ever increase it from 1? Shouldn't we unhardcode that value?
Member
Author
There was a problem hiding this comment.
yes, this is addressed in lasse's pr -- but will apply here too
Comment on lines
+68
to
+69
| const [versionVersion, l1ChainId, l1RollupAddress, rollupVersion, l2ProtocolContractsTreeRoot, l2CircuitsVkTreeRoot] = | ||
| compressed.split('-'); |
Contributor
There was a problem hiding this comment.
Doesn't the rollup address imply the rollup version? If we're including the rollup address in here, couldn't we remove the rollup version?
Contributor
There was a problem hiding this comment.
In the change made in #13171, only the rollupVersion should be needed since the rollup address, l1 chain id and genesis state is hashed together to get the compute it 👀
Maddiaa0
force-pushed
the
md/alpha-testnet-version
branch
from
2ab2e16 to
b31a57b
Compare
Maddiaa0
force-pushed
the
md/alpha-testnet-version
branch
from
3330459 to
a48e2e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply #13145 to alpha testnet