Skip to content

chore: drop unused CLI options #13000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
Mar 27, 2025
Merged

chore: drop unused CLI options #13000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions yarn-project/cli/src/cmds/l1/deploy_l1_verifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,9 @@ export async function deployUltraHonkVerifier(
privateKey: string | undefined,
mnemonic: string,
pxeRpcUrl: string,
bbBinaryPath: string,
bbWorkingDirectory: string,
log: LogFn,
debugLogger: Logger,
) {
if (!bbBinaryPath || !bbWorkingDirectory) {
throw new InvalidOptionArgumentError('Missing path to bb binary and working directory');
}

const { publicClient, walletClient } = createL1Clients(
ethRpcUrls,
privateKey ?? mnemonic,
Expand Down
6 changes: 0 additions & 6 deletions yarn-project/cli/src/cmds/l1/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ const l1RpcUrlsOption = new Option(
.argParser((arg: string) => arg.split(',').map(url => url.trim()));

export function injectCommands(program: Command, log: LogFn, debugLogger: Logger) {
const { BB_BINARY_PATH, BB_WORKING_DIRECTORY } = process.env;

program
.command('deploy-l1-contracts')
.description('Deploys all necessary Ethereum contracts for Aztec.')
Expand Down Expand Up @@ -412,8 +410,6 @@ export function injectCommands(program: Command, log: LogFn, debugLogger: Logger
'test test test test test test test test test test test junk',
)
.requiredOption('--verifier <verifier>', 'Either mock or real', 'real')
.option('--bb <path>', 'Path to bb binary', BB_BINARY_PATH)
.option('--bb-working-dir <path>', 'Path to bb working directory', BB_WORKING_DIRECTORY)
.action(async options => {
const { deployMockVerifier, deployUltraHonkVerifier } = await import('./deploy_l1_verifier.js');
if (options.verifier === 'mock') {
Expand All @@ -435,8 +431,6 @@ export function injectCommands(program: Command, log: LogFn, debugLogger: Logger
options.l1PrivateKey,
options.mnemonic,
options.rpcUrl,
options.bb,
options.bbWorkingDir,
log,
debugLogger,
);
Expand Down