Skip to content

fix: parse away trailing slash from consensus host #12577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maddiaa0 merged 3 commits into from
Mar 26, 2025
Merged

fix: parse away trailing slash from consensus host #12577

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faa4855
fix: parse away trailing / from consensus host
koenmtb1 Mar 7, 2025
a566134
fix: move consensus trailing / check to same location as api key set
koenmtb1 Mar 7, 2025
de2241b
Merge branch 'master' into master
Maddiaa0 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion yarn-project/blob-sink/src/client/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,12 @@ export const blobSinkConfigMapping: ConfigMappingsType<BlobSinkConfig> = {
* @returns The blob sink configuration.
*/
export function getBlobSinkConfigFromEnv(): BlobSinkConfig {
return getConfigFromMappings<BlobSinkConfig>(blobSinkConfigMapping);
const config = getConfigFromMappings<BlobSinkConfig>(blobSinkConfigMapping);

// check if l1ConsensusHostUrl has a trailing '/' and remove it
if (config.l1ConsensusHostUrl && config.l1ConsensusHostUrl.endsWith('/')) {
config.l1ConsensusHostUrl = config.l1ConsensusHostUrl.slice(0, -1);
}

return config;
}
Loading