feat(avm): operand decomposition into bytes by jeanmon · Pull Request #12182 · AztecProtocol/aztec-packages

jeanmon · 2025-02-21T10:09:54Z

----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
alu_acc                                0.121 us        0.121 us      5785052
bc_decomposition_acc                    11.0 us         11.0 us        63532
bc_decomposition_interactions_acc       1.10 us         1.10 us       634797
bc_retrieval_acc                       0.025 us        0.025 us     28546642
bitwise_acc                             1.49 us         1.49 us       470471
bitwise_interactions_acc               0.923 us        0.923 us       759252
ecc_acc                                 2.58 us         2.58 us       270979
execution_acc                          0.520 us        0.520 us      1349788
instr_fetching_acc                      6.99 us         6.99 us       100165
poseidon2_hash_acc                      1.84 us         1.84 us       381127
poseidon2_hash_interactions_acc        0.742 us        0.742 us       942127
poseidon2_perm_acc                      44.6 us         44.6 us        15735
range_check_acc                         2.68 us         2.68 us       261062
range_check_interactions_acc            3.53 us         3.53 us       198400
sha256_acc                              6.25 us         6.25 us       112184
sha256_interactions_acc                0.400 us        0.400 us      1749677

fcarreiro

Sending you some initial comments while I think more about the tests.

barretenberg/cpp/pil/vm2/precomputed.pil

barretenberg/cpp/src/barretenberg/vm/avm/tests/inter_table.test.cpp

barretenberg/cpp/pil/vm2/instr_fetching.pil

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/op_decomposition.test.cpp

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/instr_fetching.test.cpp

barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.hpp

barretenberg/cpp/pil/vm2/instr_fetching.pil

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/instr_fetching.test.cpp

barretenberg/cpp/src/barretenberg/vm2/tracegen/bytecode_trace.cpp

fcarreiro · 2025-02-21T11:23:26Z

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/instr_fetching.test.cpp

Please add a todo to include interaction tests (you can do it next week)

barretenberg/cpp/pil/vm2/instr_fetching.pil

barretenberg/cpp/src/barretenberg/vm2/simulation/lib/serialization.hpp

fcarreiro

Approving under oath of solving everything when you are back :)

barretenberg/cpp/src/barretenberg/vm2/common/instruction_spec.hpp

barretenberg/cpp/src/barretenberg/vm2/simulation/lib/serialization.cpp

barretenberg/cpp/src/barretenberg/vm2/simulation/lib/serialization.hpp

barretenberg/cpp/src/barretenberg/vm2/tracegen/precomputed_trace.cpp

file

header file

jeanmon · 2025-02-21T17:30:08Z

Approving under oath of solving everything when you are back :)

Ticket #12193 opened and assigned to me.

jeanmon force-pushed the jm/instr-decomposition branch from 2757884 to c7e31f3 Compare February 21, 2025 10:18

jeanmon marked this pull request as ready for review February 21, 2025 10:20

jeanmon requested review from IlyasRidhuan, Maddiaa0 and fcarreiro as code owners February 21, 2025 10:20

jeanmon removed request for IlyasRidhuan and Maddiaa0 February 21, 2025 10:20